-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CORE] Dependencies are now moved to Directory.Package.props
#6729
base: dev
Are you sure you want to change the base?
Changes from 1 commit
125cde3
f6a173c
ff74505
6aed101
08cf7eb
4275377
1d974db
4f46a4d
1840f31
59479ae
d1c4fa9
b4c39ef
a78e34d
507de6d
5442472
a2b8888
15c8997
38ec1be
a84988a
ce30ae2
536c6ad
6e5c85d
61cfba3
b10f5ba
38a56ce
60d4789
0968e1d
033f6be
41bbbe9
790e692
e5db73c
34a8efd
f992f43
c70c350
ad9b282
df50540
77bc827
1e220d5
6ccb855
f6dd578
b5e6f52
49f3f4b
e52a477
4feac9b
5483503
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
<Project> | ||
<Import Project="$([MSBuild]::GetPathOfFileAbove('Directory.Build.props', '$(MSBuildThisFileDirectory)../'))" /> | ||
|
||
<!-- SourceLink support for all Akka.NET projects --> | ||
<ItemGroup> | ||
<PackageReference Include="Microsoft.SourceLink.GitHub" Version="1.1.1" PrivateAssets="All" /> | ||
</ItemGroup> | ||
</Project> |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
<Project> | ||
<Import Project="$([MSBuild]::GetPathOfFileAbove('Directory.Build.props', '$(MSBuildThisFileDirectory)../'))" /> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Import There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same as above. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
|
||
<!-- SourceLink support for all Akka.NET projects --> | ||
<ItemGroup> | ||
<PackageReference Include="Microsoft.SourceLink.GitHub" PrivateAssets="All" /> | ||
</ItemGroup> | ||
</Project> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Import
Directory.Build.props
fromsrc
directoryThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not just have one
Directory.Build.props
file that governs everything?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SourceLink support for all Akka.NET projects
: we needcontrib/Directory.Build.props
and I addedPackageReference Include="Microsoft.SourceLink.GitHub" Version="1.1.1" PrivateAssets="All"
to fix it