Skip to content

[BACKPORT] move Move Channel Stages from Alpakka to main project. #6317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 20, 2022

Conversation

Aaronontheweb
Copy link
Member

Backport of #6268

Changes

Changes

  • Moves Alpakka Channels Extension into the main project.
  • Appends DSLs for main Source and Sink to have Channel methods
  • Adds capability for a Channel Source with a materialized ChannelWriter<T> result
    • This feels more symmetrical with the Sink API that allows both options, and allows for a better option-in-place-of Source.Queue<T>.

The main motivations for this are as follows:

  • We already take System.Threading.Channels as a dep in core Akka
  • We can probably get rid of the ugly backing code behind RunAsAsyncEnumerable, even if it is a minorly-breaking API change it may be better long term.

Checklist

For significant changes, please ensure that the following have been completed (delete if not relevant):

Sorry, something went wrong.

to11mtm and others added 2 commits December 20, 2022 11:47

Verified

This commit was signed with the committer’s verified signature.
Aaronontheweb Aaron Stannard
* Move Channel Stages from Alpakka to main project.

* added API approvals

Co-authored-by: Aaron Stannard <aaron@petabridge.com>

Verified

This commit was signed with the committer’s verified signature.
Aaronontheweb Aaron Stannard
@Aaronontheweb Aaronontheweb added akka-streams api-change akka.net v1.4 Issues affecting Akka.NET v1.4 labels Dec 20, 2022
@Aaronontheweb Aaronontheweb added this to the 1.4.48 milestone Dec 20, 2022
@Aaronontheweb Aaronontheweb enabled auto-merge (squash) December 20, 2022 17:51
@Aaronontheweb Aaronontheweb merged commit fb507b1 into akkadotnet:v1.4 Dec 20, 2022
@Aaronontheweb Aaronontheweb deleted the akka-streams-stage branch December 20, 2022 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
akka.net v1.4 Issues affecting Akka.NET v1.4 akka-streams api-change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants