Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trap all exception thrown while trying to dispatch messages in Akka.Remote.EndpointReader #5971

Merged
merged 1 commit into from May 27, 2022
Merged

Trap all exception thrown while trying to dispatch messages in Akka.Remote.EndpointReader #5971

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
14 changes: 1 addition & 13 deletions src/core/Akka.Remote/Endpoint.cs
View file
Open in desktop
Expand Up @@ -1953,21 +1953,9 @@ private void Reading()
ackAndMessage.MessageOption.SerializedMessage,
ackAndMessage.MessageOption.SenderOptional);
}
catch (SerializationException e)
{
LogTransientSerializationError(ackAndMessage.MessageOption, e);
}
catch (ArgumentException e)
{
LogTransientSerializationError(ackAndMessage.MessageOption, e);
}
catch (InvalidCastException e)
{
LogTransientSerializationError(ackAndMessage.MessageOption, e);
}
catch (Exception e)
{
throw;
LogTransientSerializationError(ackAndMessage.MessageOption, e);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have to just make this a catch all because libraries like Newtonsoft.Json don't throw either of the handled cases above. If you have a serialization problem, it's your fault - we'll log it and not let it blow up the connection. On the user to fix it.

}
}
}
Expand Down