ddata ReadMajorityPlus and WriteMajorityPlus #5146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…est in ddata writes and reads (partially migrated from akka/akka#28895)
There was a problem hiding this comment.
Overall, looks good to me - left you some questions though @zbynek001
| ExpectTerminated(replicator, TimeSpan.FromSeconds(10)); | ||
| var terminated1 = ExpectMsg<Terminated>(TimeSpan.FromSeconds(10)); | ||
| var terminated2 = ExpectMsg<Terminated>(TimeSpan.FromSeconds(10)); | ||
| ImmutableHashSet.Create(terminated1.ActorRef, terminated2.ActorRef).Should().BeEquivalentTo(durableStore, replicator); |
There was a problem hiding this comment.
Nice, that should make this test less racy
| @@ -85,7 +85,7 @@ public WriteAckAdapter(IActorRef replica) | |||
| private readonly Address _nodeB = new Address("akka.tcp", "Sys", "b", 2552); | |||
| private readonly Address _nodeC = new Address("akka.tcp", "Sys", "c", 2552); | |||
| private readonly Address _nodeD = new Address("akka.tcp", "Sys", "d", 2552); | |||
| private readonly IImmutableSet<Address> _nodes; | |||
| private readonly IImmutableList<Address> _nodes; | |||
There was a problem hiding this comment.
Why the change from set to list?
There was a problem hiding this comment.
because the base class ReadWriteAggregator changes of nodes from IImmutableSet to IImmutableList to keep the order of nodes by oldest for the PreferOldest scenario.
| var n = Nodes.Count + 1; | ||
| var r = CalculateMajority(read.MinCapacity, n, read.Additional); | ||
| Log.Debug("ReadMajorityPlus [{0}] [{1}] of [{2}].", _key, r, n); | ||
| return n - r; |
| // When RequiresCausalDeliveryOfDeltas (shuffle=false) use deterministic order to so that sequence numbers | ||
| // of subsequent updates are in sync on the destination nodes. | ||
| // The order is also kept when prefer-oldest is enabled. | ||
| var orderedNodes = Shuffle ? |
There was a problem hiding this comment.
The comment above makes sense - thank you
|
|
||
| return Math.Max(minCapacity, numberOfNodes / 2 + 1); | ||
| var majority = numberOfNodes / 2 + 1; | ||
| return Math.Min(numberOfNodes, Math.Max(majority + additional, minCapacity)); |
| { | ||
| proto.ConsistencyAdditional = rmp.Additional; | ||
| proto.HasConsistencyAdditional = true; | ||
| } |
| Log.Debug("WriteMajorityPlus [{0}] [{1}] of [{2}].", _key, w, n); | ||
| return n - w; | ||
| } | ||
| case WriteLocal _: throw new ArgumentException("WriteAggregator does not support WriteLocal"); |
| /// <see cref="WriteMajority"/> but with the given number of <see cref="Additional"/> nodes added to the majority count. At most | ||
| /// all nodes. | ||
| /// </summary> | ||
| public sealed class WriteMajorityPlus : IWriteConsistency, IEquatable<WriteMajorityPlus> |
|
|
||
| # Update and Get operations are sent to oldest nodes first. | ||
| # This is useful together with Cluster Singleton, which is running on oldest nodes. | ||
| prefer-oldest = off |
| @@ -17,6 +17,7 @@ message Get { | |||
| int32 consistencyMinCap = 5; | |||
| bool hasConsistencyAdditional = 6; | |||
| int32 consistencyAdditional = 7; | |||
| bool hasConsistencyMinCap = 8; | |||
This was referenced Aug 5, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New ReadMajorityPlus and WriteMajorityPlus
Possibility to prefer oldest in ddata writes and reads
(partially migrated from akka/akka#28895)