Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

log full exception upon deserialization failure #5121

Merged
merged 1 commit into from
Jul 5, 2021
Merged

log full exception upon deserialization failure #5121

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/core/Akka.Remote/Endpoint.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1500,7 +1500,7 @@ private bool WriteSend(EndpointManager.Send send)
{
_log.Error(
ex,
"Serializer not defined for message type [{0}]. Transient association error (association remains live)",
"Serialization failed for message [{0}]. Transient association error (association remains live)",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made this message less specific, since we don't necessarily know why an outbound write failed.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(the inner exception should tell us)

send.Message.GetType());
return true;
}
Expand Down Expand Up @@ -1981,8 +1981,8 @@ private void Reading()
private void LogTransientSerializationError(Message msg, Exception error)
{
var sm = msg.SerializedMessage;
_log.Warning(
"Serializer not defined for message with serializer id [{0}] and manifest [{1}]. " +
_log.Warning(error,
"Deserialization failed for message with serializer id [{0}] and manifest [{1}]. " +
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passed in the Exception as a parameter and made it clear that this was a read-side failure, not a write-side failure

"Transient association error (association remains live). {2}",
sm.SerializerId,
sm.MessageManifest.IsEmpty ? "" : sm.MessageManifest.ToStringUtf8(),
Expand Down