Fix Akka.Remote serialization exception bubbling and messages

src/core/Akka.Remote.Tests/Akka.Remote.Tests.csproj

@@ -8,6 +8,7 @@
   </PropertyGroup>
 
   <ItemGroup>
+    <ProjectReference Include="..\..\contrib\cluster\Akka.DistributedData\Akka.DistributedData.csproj" />
     <ProjectReference Include="..\Akka.Remote\Akka.Remote.csproj" />
     <ProjectReference Include="..\Akka.Tests.Shared.Internals\Akka.Tests.Shared.Internals.csproj" />
 

src/core/Akka.Remote.Tests/Serialization/BugFix5062Spec.cs

@@ -0,0 +1,97 @@
+using System;
+using System.Collections.Generic;
+using System.Linq;
+using System.Reflection;
+using System.Runtime.Serialization;
+using System.Text;
+using System.Threading.Tasks;
+using Akka.Actor;
+using Akka.Cluster;
+using Akka.Configuration;
+using Akka.DistributedData;
+using Akka.Remote.Configuration;
+using Akka.Serialization;
+using Akka.TestKit;
+using FluentAssertions;
+using Google.Protobuf;
+using Xunit;
+using Xunit.Abstractions;
+
+namespace Akka.Remote.Tests.Serialization
+{
+    public class BugFix5062Spec: AkkaSpec
+    {
+        private static Config DDataConfig => ConfigurationFactory.ParseString($@"
+            akka.actor {{
+                serializers {{
+                    dummyWithManifest = ""{typeof(DummySerializerWithStringManifest).AssemblyQualifiedName}""
+                }}
+                serialization-bindings {{
+                    ""{typeof(SomeMessage).AssemblyQualifiedName}"" = dummyWithManifest
+                }}
+                serialization-identifiers {{
+	                ""{typeof(DummySerializerWithStringManifest).AssemblyQualifiedName}"" = 13
+                }}
+            }}")
+            .WithFallback(RemoteConfigFactory.Default())
+            .WithFallback(DistributedData.DistributedData.DefaultConfig());
+
+        public BugFix5062Spec(ITestOutputHelper output) : base(output, DDataConfig)
+        { }
+
+        [Fact]
+        public void Failed_serialization_should_give_proper_exception_message()
+        {
+            var node1 = new UniqueAddress(new Address("akka.tcp", "Sys", "localhost", 2551), 1);
+            var payload = new LWWRegister<SomeMessage>(node1, new SomeMessage());
+
+            var message = new ActorSelectionMessage(
+                payload, 
+                new SelectionPathElement[] { new SelectChildName("dummy") }, 
+                true);
+
+            var serialized = MessageSerializer.Serialize((ExtendedActorSystem)Sys, node1.Address, message);
+
+            var o = new object();
+            var ex = o.Invoking(s => MessageSerializer.Deserialize((ExtendedActorSystem)Sys, serialized)).Should()
+                .Throw<SerializationException>()
+                .WithMessage("Failed to deserialize object with serialization id [6] (manifest []).")
+                .WithInnerExceptionExactly<SerializationException>()
+                .WithMessage("Failed to deserialize object with serialization id [11] (manifest [E]).")
+                .WithInnerExceptionExactly<TargetInvocationException>()
+                .WithMessage("Exception has been thrown by the target of an invocation.")
+                .WithInnerExceptionExactly<SerializationException>()
+                .WithMessage("Failed to deserialize object with serialization id [13] (manifest [SM]).");
+        }
+
+        public class SomeMessage
+        {
+        }
+
+        public class DummySerializerWithStringManifest : SerializerWithStringManifest
+        {
+            public DummySerializerWithStringManifest(ExtendedActorSystem system) : base(system)
+            {
+            }
+
+            public override byte[] ToBinary(object obj)
+            {
+                return Array.Empty<byte>();
+            }
+
+            public override object FromBinary(byte[] bytes, string manifest)
+            {
+                throw new NotImplementedException();
+            }
+
+            public override string Manifest(object o)
+            {
+                if (o is SomeMessage)
+                    return "SM";
+                throw new Exception("Unknown object type");
+            }
+        }
+
+
+    }
+}

src/core/Akka/Serialization/Serialization.cs

@@ -429,6 +429,11 @@ public object Deserialize(byte[] bytes, int serializerId, string manifest)
 
                 return serializer.FromBinary(bytes, type);
             }
+            catch (Exception e)
+            {
+                throw new SerializationException(
+                    $"Failed to deserialize object with serialization id [{serializerId}] (manifest [{manifest}]).", e);
+            }
             finally
             {
                 Serialization.CurrentTransportInformation = oldInfo;