Removed StringBuilder allocation from Base64Encoding
#5051
Conversation
|
|
||
| public static string Base64Encode(this long value, string prefix) | ||
| { | ||
| Span<char> sb = stackalloc char[11 + prefix?.Length ?? 0]; |
There was a problem hiding this comment.
Testing program is here:
https://gist.github.com/Aaronontheweb/449d565754d5f9bce475653842317277
11 is the number of characters it takes to represent long.MaxValue in base64 encoded strings
|
|
||
| /// <summary> | ||
| /// TBD | ||
| /// </summary> | ||
| /// <param name="value">TBD</param> | ||
| /// <param name="sb">TBD</param> | ||
| /// <returns>TBD</returns> | ||
| [Obsolete("Do not use. Pass in prefix as a string instead.")] |
There was a problem hiding this comment.
Should we change this comment, since our method that takes string is internal now?
There was a problem hiding this comment.
Still useful since this method really shouldn't have been exposed as public anyway, IMHO
There was a problem hiding this comment.
We had a bad habit in the very early days of Akka.NET making a lot of the internals public "in case someone wanted to play with them!" and we've been gradually undoing that in our minor version releases....
| do | ||
| { | ||
| var index = (int)(next & 63); | ||
| sb[spanIndex++] = Base64Chars[index]; |
There was a problem hiding this comment.
I wonder, is there any advantage at this point to changing Base64Chars to ReadOnlyMemory?
There was a problem hiding this comment.
I don't think so since it's basically just integer accessors
Before (ActorSelection + Ask)
After (ActorSelection + Ask)