Grf 535 : Get the template from the database (replace GetTemplateInMemory) #18288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/Akeneo/Category/front/src/feature/pages/TemplatePage.tsx
jeremyBeaucousinAkeneo
force-pushed
the
GRF-535
branch
2 times, most recently
from
01b650d
to
45d19ea
Compare
jeremyBeaucousinAkeneo
changed the title
jeremyBeaucousinAkeneo
force-pushed
the
GRF-535
branch
from
45d19ea
to
710e9fc
Compare
jeremyBeaucousinAkeneo
force-pushed
the
GRF-535
branch
from
3256697
to
c89e485
Compare
BryanS29-akeneo
approved these changes
Oct 31, 2022
src/Akeneo/Category/back/Infrastructure/Controller/InternalApi/ImagePreviewController.php
Outdated
Show resolved
Hide resolved
GRF-535 : Create dedicated interface for AttributeTemplateInMemory
jeremyBeaucousinAkeneo
force-pushed
the
GRF-535
branch
from
78f43ec
to
16ae7d9
Compare
src/Akeneo/Category/back/Infrastructure/Controller/InternalApi/GetTemplateController.php
Show resolved
Hide resolved
src/Akeneo/Category/back/Infrastructure/Storage/InMemory/GetTemplateInMemory.php
Outdated
Show resolved
Hide resolved
src/Akeneo/Category/front/src/feature/hooks/useTemplateByTemplateUuidInMemory.ts
Outdated
Show resolved
Hide resolved
src/Akeneo/Category/back/Infrastructure/Storage/InMemory/GetAttributeInMemoryImpl.php
Show resolved
Hide resolved
src/Akeneo/Category/back/Infrastructure/Controller/InternalApi/GetTemplateController.php
Outdated
Show resolved
Hide resolved
src/Akeneo/Category/back/Infrastructure/Symfony/Resources/config/queries.yml
Outdated
Show resolved
Hide resolved
jeremyBeaucousinAkeneo
force-pushed
the
GRF-535
branch
from
1580285
to
68ca53a
Compare
jeremyBeaucousinAkeneo
force-pushed
the
GRF-535
branch
from
68ca53a
to
98cd6d5
Compare
BryanS29-akeneo
approved these changes
Nov 2, 2022
src/Akeneo/Category/back/Infrastructure/Storage/InMemory/GetAttributeInMemoryImpl.php
Show resolved
Hide resolved
src/Akeneo/Category/back/Infrastructure/Builder/TemplateBuilder.php
Outdated
Show resolved
Hide resolved
src/Akeneo/Category/back/Infrastructure/Controller/InternalApi/GetTemplateController.php
Show resolved
Hide resolved
src/Akeneo/Category/back/tests/Integration/Helper/CategoryTestCase.php
Outdated
Show resolved
Hide resolved
src/Akeneo/Category/back/Infrastructure/Controller/InternalApi/GetTemplateController.php
Show resolved
Hide resolved
antoinetrouve
approved these changes
Nov 2, 2022
...ategory/back/tests/Integration/Infrastructure/Storage/Sql/GetCategoryTemplateIntegration.php
Show resolved
Hide resolved
jeremyBeaucousinAkeneo
added a commit
that referenced
this pull request
Nov 2, 2022
* GRF-357: Update database and models * GRF-357: Create category template table for pim-dev * GRF-509 add service to generate template Model based on a category tree code * GRF-358: WIP * GRF-509 create private functions to auto generate template's code and label * wip 2 * GRF-289: Fix load builders.yml * GRF-360: Add create category controller (#18153) * GRF-357: Update database and models pim_catalog_category_tree_template * GRF-357: Create category template tree table for pim-dev * wip 3 * GRF-357: Update database add column category_template_uuid on pim_catalog_category * GRF-357: Add category_template_uuid on pim_catalog_category for pim-dev * GRF-357: GRF-357: Update database and models pim_catalog_category_attribute * GRF-357: Create category attribute table for pim-dev * GRF-357: Delete relation between category and template * GRF-357: Delete relation between category and template * GRF-357: Update model with new fields * GRF-357: fix AttributeAdditionalProperties model * GRF-357: fix AttributeAdditionalProperties IteratorAggregate value to mixed * GRF-357: lint fix * GRF-357: fix tests * GRF-357: Fix database test error * GRF-357: Change isYes to getValue * GRF-357: Change add value_collection SQL script * GRF-357: Change identifier to uuid on pim_catalog_category_attribute * GRF-289: Create model CategoryTree and service GetCategoryTreesSql * GRF-289: Adapt integration test * GRF-289: Crete fromDatabse function in Category and CategoryTree models * wip 4 * GRF-492: Attribute tab should be in first place (#18204) * GRF-492: Attribute tab should be in first place * GRF-492: Fix default active tab * GRF-492: fix not necessary dependencies * GRF-289: Create model CategoryTree and service GetCategoryTreesSql (#18223) * GRF-289: Create model CategoryTree and service GetCategoryTreesSql * GRF-289: Adapt integration test * GRF-289: Crete fromDatabse function in Category and CategoryTree models * GRF-492: fix phpstan and lint * GRF-511 : Routing and Template page initialization * GRF-511 : Routing and Template page Finalization * GRF-511 : Routing and Template page optimization * GRF-371: Update models (#18243) * GRF-371: Display category templates column and hide it where there is no template (#18163) * GRF-289: Clean up retrieving category trees * GRF-289: Display ctageory templates column * GRF-371: Query to get trees * GRF-371: Query to get trees in proper service * GRF-371: update categorytreecontroller * GRF-371: Create query to get category trees by ids * GRF-371: fix integration tests * GRF-371: display column category templates if trees have templates * GRF-357: fix check trees has templates * GRF-371: Associate a template to the category * GRF-371: Fix uilocale to cataloglocale * GRF-371: fix * GRF-371: fix CategoryTree instead of Category * GRF-371: fix lint * GRF-371: get template label in the controller from CategoryTree * GRF-371: fix get template labels * GRF-371: Update models * wip 5 * GRF-358: remove DSM update * GRF-358: Apply changes to button in tree page * GRF-358: fix merge conflict error * GRF-358: removed console.log * GRF-296: Fix rights to display category templates column * GRF-511 : Populate template properties * GRF-357: Update database and models * GRF-357: Create category template table for pim-dev * GRF-357: Update database and models pim_catalog_category_tree_template * GRF-357: Create category template tree table for pim-dev * GRF-357: Update database add column category_template_uuid on pim_catalog_category * GRF-357: Add category_template_uuid on pim_catalog_category for pim-dev * GRF-357: GRF-357: Update database and models pim_catalog_category_attribute * GRF-357: Create category attribute table for pim-dev * GRF-357: Delete relation between category and template * GRF-357: Delete relation between category and template * GRF-357: Update model with new fields * GRF-509 add service to generate template Model based on a category tree code * GRF-509 create private functions to auto generate template's code and label * GRF-289: Fix load builders.yml * GRF-360: Add create category controller (#18153) * GRF-357: fix AttributeAdditionalProperties model * GRF-357: fix AttributeAdditionalProperties IteratorAggregate value to mixed * GRF-357: lint fix * GRF-357: fix tests * GRF-357: Fix database test error * GRF-357: Change isYes to getValue * GRF-357: Change add value_collection SQL script * GRF-357: Change identifier to uuid on pim_catalog_category_attribute * GRF-289: Create model CategoryTree and service GetCategoryTreesSql (#18223) * GRF-289: Create model CategoryTree and service GetCategoryTreesSql * GRF-289: Adapt integration test * GRF-289: Crete fromDatabse function in Category and CategoryTree models * GRF-492: fix phpstan and lint * GRF-371: Update models (#18243) * GRF-358: Implement Activate template buttons for template activation and redirection to template view page (#18248) * GRF-358: implementation of activate/edit template buttons on tree and tree grid pages Co-authored-by: Bryan Stéphan <bryan.stephan@akeneo.com> * GRF-289: Fix display action buttons * GRF-289: lint fix * GRF-289: lint fix * GRF-511 : Labels of properties in read only * GRF-289: lint fix * GRF-289: lint fix * GRF-511 : Delete useless comments * GRF-511 : Fix routing definition issue * GRF-513 : Template form (#18279) * GRF-513 : First implementation of attributes tab * GRF-513 : Restructuration of attribute page with list and selection * GRF-513 : Refactoring useTemplate * Grf 535 : Get the template from the database (replace GetTemplateInMemory) (#18288) * GRF-535 : Replace Template in Memory by GetTemplateSql * GRF-535 : Create differentes routes for templateSql and InMemory * GRF-535 : Populate the categoryId on Template * GRF-535 : Populate template with attributes from database * GRF-535 : Fix linter issue * GRF-535 : Create dedicated interface for AttributeTemplateInMemory GRF-535 : Create dedicated interface for AttributeTemplateInMemory * GRF-535 : Fix tests * GRF-535 : Fix tests * GRF-535 : Fix tests Co-authored-by: Bryan Stéphan <bryan.stephan@akeneo.com> Co-authored-by: Adrien Migaire <adrien.migaire@akeneo.com> Co-authored-by: etienne-kerbastard <etienne.kerbastard@akeneo.com> Co-authored-by: amigaire <94356747+amigaire@users.noreply.github.com> Co-authored-by: Bryan Stéphan <85103635+BryanS29-akeneo@users.noreply.github.com> Co-authored-by: etiennekerbastard <42570470+etiennekerbastard@users.noreply.github.com>
jeremyBeaucousinAkeneo
added a commit
that referenced
this pull request
Nov 7, 2022
* GRF-289: As Julia, I want to activate a static template per category tree (#18160) * GRF-357: Update database and models * GRF-357: Create category template table for pim-dev * GRF-357: Update database and models pim_catalog_category_tree_template * GRF-357: Create category template tree table for pim-dev * GRF-357: Update database add column category_template_uuid on pim_catalog_category * GRF-357: Add category_template_uuid on pim_catalog_category for pim-dev * GRF-357: GRF-357: Update database and models pim_catalog_category_attribute * GRF-357: Create category attribute table for pim-dev * GRF-357: Delete relation between category and template * GRF-357: Delete relation between category and template * GRF-357: Update model with new fields * GRF-509 add service to generate template Model based on a category tree code * GRF-509 create private functions to auto generate template's code and label * GRF-289: Fix load builders.yml * GRF-360: Add create category controller (#18153) * GRF-357: fix AttributeAdditionalProperties model * GRF-357: fix AttributeAdditionalProperties IteratorAggregate value to mixed * GRF-357: lint fix * GRF-357: fix tests * GRF-357: Fix database test error * GRF-357: Change isYes to getValue * GRF-357: Change add value_collection SQL script * GRF-357: Change identifier to uuid on pim_catalog_category_attribute * GRF-289: Create model CategoryTree and service GetCategoryTreesSql (#18223) * GRF-289: Create model CategoryTree and service GetCategoryTreesSql * GRF-289: Adapt integration test * GRF-289: Crete fromDatabse function in Category and CategoryTree models * GRF-492: fix phpstan and lint * GRF-371: Update models (#18243) * GRF-358: Implement Activate template buttons for template activation and redirection to template view page (#18248) * GRF-358: implementation of activate/edit template buttons on tree and tree grid pages Co-authored-by: Bryan Stéphan <bryan.stephan@akeneo.com> * GRF-289: lint fix * GRF-361 fix phpDoc * GRF-361 add category template creation in database * GRF-361 remove template's attribute insertion from createTemplate service * GRF-361 improve responsibility isolation in template saving services * GRF-361 WIP fixing unit tests * GRF-361 refacto services and queries * GRF-361 add integration test of ActivateTemplate service * GRF-361 add basic cases in integration tests * GRF-361 use newly introduced CategoryTree model * GRF-361 improve sql queries * GRF-361 add generate mocked template function in CategoryTestCase * GRF-361 refacto insert query of category template attributes * GRF-361 refacto integration tests * GRF-361 fixes after rebase of GRF-289 * GRF-361 refacto activeTemplate service reduce queries number * GRF-361 fix phpstan * GRF-289 fix controller Co-authored-by: jeremy-beaucousin <jeremy.beaucousin@akeneo.com> Co-authored-by: Adrien Migaire <adrien.migaire@akeneo.com> Co-authored-by: etiennekerbastard <42570470+etiennekerbastard@users.noreply.github.com> * GRF-296: As Julia, I want to go on managing simple categories (#18229) * GRF-357: Update database and models * GRF-357: Create category template table for pim-dev * GRF-509 add service to generate template Model based on a category tree code * GRF-509 create private functions to auto generate template's code and label * GRF-289: Fix load builders.yml * GRF-360: Add create category controller (#18153) * GRF-357: Update database and models pim_catalog_category_tree_template * GRF-357: Create category template tree table for pim-dev * GRF-357: Update database add column category_template_uuid on pim_catalog_category * GRF-357: Add category_template_uuid on pim_catalog_category for pim-dev * GRF-357: GRF-357: Update database and models pim_catalog_category_attribute * GRF-357: Create category attribute table for pim-dev * GRF-357: Delete relation between category and template * GRF-357: Delete relation between category and template * GRF-357: Update model with new fields * GRF-357: fix AttributeAdditionalProperties model * GRF-357: fix AttributeAdditionalProperties IteratorAggregate value to mixed * GRF-357: lint fix * GRF-357: fix tests * GRF-357: Fix database test error * GRF-357: Change isYes to getValue * GRF-357: Change add value_collection SQL script * GRF-357: Change identifier to uuid on pim_catalog_category_attribute * GRF-492: Attribute tab should be in first place (#18204) * GRF-492: Attribute tab should be in first place * GRF-492: Fix default active tab * GRF-492: fix not necessary dependencies * GRF-289: Create model CategoryTree and service GetCategoryTreesSql (#18223) * GRF-289: Create model CategoryTree and service GetCategoryTreesSql * GRF-289: Adapt integration test * GRF-289: Crete fromDatabse function in Category and CategoryTree models * GRF-492: fix phpstan and lint * GRF-371: Update models (#18243) * GRF-371: Display category templates column and hide it where there is no template (#18163) * GRF-289: Clean up retrieving category trees * GRF-289: Display ctageory templates column * GRF-371: Query to get trees * GRF-371: Query to get trees in proper service * GRF-371: update categorytreecontroller * GRF-371: Create query to get category trees by ids * GRF-371: fix integration tests * GRF-371: display column category templates if trees have templates * GRF-357: fix check trees has templates * GRF-371: Associate a template to the category * GRF-371: Fix uilocale to cataloglocale * GRF-371: fix * GRF-371: fix CategoryTree instead of Category * GRF-371: fix lint * GRF-371: get template label in the controller from CategoryTree * GRF-371: fix get template labels * GRF-371: Update models * GRF-296: Fix rights to display category templates column * GRF-296: fix getValue on value object CategoryId Co-authored-by: Adrien Migaire <adrien.migaire@akeneo.com> Co-authored-by: amigaire <94356747+amigaire@users.noreply.github.com> Co-authored-by: jeremy-beaucousin <jeremy.beaucousin@akeneo.com> Co-authored-by: jeremyBeaucousinAkeneo <114410848+jeremyBeaucousinAkeneo@users.noreply.github.com> * GRF-491: Have category edition page locale be in sync with the catalog locale (#18274) * GRF-96: lint fix * GRF-539 plug template attribute saver to activateTemplate process (#18285) * GRF-358: Add view template button (#18291) * Grf 510 (#18286) * GRF-357: Update database and models * GRF-357: Create category template table for pim-dev * GRF-509 add service to generate template Model based on a category tree code * GRF-358: WIP * GRF-509 create private functions to auto generate template's code and label * wip 2 * GRF-289: Fix load builders.yml * GRF-360: Add create category controller (#18153) * GRF-357: Update database and models pim_catalog_category_tree_template * GRF-357: Create category template tree table for pim-dev * wip 3 * GRF-357: Update database add column category_template_uuid on pim_catalog_category * GRF-357: Add category_template_uuid on pim_catalog_category for pim-dev * GRF-357: GRF-357: Update database and models pim_catalog_category_attribute * GRF-357: Create category attribute table for pim-dev * GRF-357: Delete relation between category and template * GRF-357: Delete relation between category and template * GRF-357: Update model with new fields * GRF-357: fix AttributeAdditionalProperties model * GRF-357: fix AttributeAdditionalProperties IteratorAggregate value to mixed * GRF-357: lint fix * GRF-357: fix tests * GRF-357: Fix database test error * GRF-357: Change isYes to getValue * GRF-357: Change add value_collection SQL script * GRF-357: Change identifier to uuid on pim_catalog_category_attribute * GRF-289: Create model CategoryTree and service GetCategoryTreesSql * GRF-289: Adapt integration test * GRF-289: Crete fromDatabse function in Category and CategoryTree models * wip 4 * GRF-492: Attribute tab should be in first place (#18204) * GRF-492: Attribute tab should be in first place * GRF-492: Fix default active tab * GRF-492: fix not necessary dependencies * GRF-289: Create model CategoryTree and service GetCategoryTreesSql (#18223) * GRF-289: Create model CategoryTree and service GetCategoryTreesSql * GRF-289: Adapt integration test * GRF-289: Crete fromDatabse function in Category and CategoryTree models * GRF-492: fix phpstan and lint * GRF-511 : Routing and Template page initialization * GRF-511 : Routing and Template page Finalization * GRF-511 : Routing and Template page optimization * GRF-371: Update models (#18243) * GRF-371: Display category templates column and hide it where there is no template (#18163) * GRF-289: Clean up retrieving category trees * GRF-289: Display ctageory templates column * GRF-371: Query to get trees * GRF-371: Query to get trees in proper service * GRF-371: update categorytreecontroller * GRF-371: Create query to get category trees by ids * GRF-371: fix integration tests * GRF-371: display column category templates if trees have templates * GRF-357: fix check trees has templates * GRF-371: Associate a template to the category * GRF-371: Fix uilocale to cataloglocale * GRF-371: fix * GRF-371: fix CategoryTree instead of Category * GRF-371: fix lint * GRF-371: get template label in the controller from CategoryTree * GRF-371: fix get template labels * GRF-371: Update models * wip 5 * GRF-358: remove DSM update * GRF-358: Apply changes to button in tree page * GRF-358: fix merge conflict error * GRF-358: removed console.log * GRF-296: Fix rights to display category templates column * GRF-511 : Populate template properties * GRF-357: Update database and models * GRF-357: Create category template table for pim-dev * GRF-357: Update database and models pim_catalog_category_tree_template * GRF-357: Create category template tree table for pim-dev * GRF-357: Update database add column category_template_uuid on pim_catalog_category * GRF-357: Add category_template_uuid on pim_catalog_category for pim-dev * GRF-357: GRF-357: Update database and models pim_catalog_category_attribute * GRF-357: Create category attribute table for pim-dev * GRF-357: Delete relation between category and template * GRF-357: Delete relation between category and template * GRF-357: Update model with new fields * GRF-509 add service to generate template Model based on a category tree code * GRF-509 create private functions to auto generate template's code and label * GRF-289: Fix load builders.yml * GRF-360: Add create category controller (#18153) * GRF-357: fix AttributeAdditionalProperties model * GRF-357: fix AttributeAdditionalProperties IteratorAggregate value to mixed * GRF-357: lint fix * GRF-357: fix tests * GRF-357: Fix database test error * GRF-357: Change isYes to getValue * GRF-357: Change add value_collection SQL script * GRF-357: Change identifier to uuid on pim_catalog_category_attribute * GRF-289: Create model CategoryTree and service GetCategoryTreesSql (#18223) * GRF-289: Create model CategoryTree and service GetCategoryTreesSql * GRF-289: Adapt integration test * GRF-289: Crete fromDatabse function in Category and CategoryTree models * GRF-492: fix phpstan and lint * GRF-371: Update models (#18243) * GRF-358: Implement Activate template buttons for template activation and redirection to template view page (#18248) * GRF-358: implementation of activate/edit template buttons on tree and tree grid pages Co-authored-by: Bryan Stéphan <bryan.stephan@akeneo.com> * GRF-289: Fix display action buttons * GRF-289: lint fix * GRF-289: lint fix * GRF-511 : Labels of properties in read only * GRF-289: lint fix * GRF-289: lint fix * GRF-511 : Delete useless comments * GRF-511 : Fix routing definition issue * GRF-513 : Template form (#18279) * GRF-513 : First implementation of attributes tab * GRF-513 : Restructuration of attribute page with list and selection * GRF-513 : Refactoring useTemplate * Grf 535 : Get the template from the database (replace GetTemplateInMemory) (#18288) * GRF-535 : Replace Template in Memory by GetTemplateSql * GRF-535 : Create differentes routes for templateSql and InMemory * GRF-535 : Populate the categoryId on Template * GRF-535 : Populate template with attributes from database * GRF-535 : Fix linter issue * GRF-535 : Create dedicated interface for AttributeTemplateInMemory GRF-535 : Create dedicated interface for AttributeTemplateInMemory * GRF-535 : Fix tests * GRF-535 : Fix tests * GRF-535 : Fix tests Co-authored-by: Bryan Stéphan <bryan.stephan@akeneo.com> Co-authored-by: Adrien Migaire <adrien.migaire@akeneo.com> Co-authored-by: etienne-kerbastard <etienne.kerbastard@akeneo.com> Co-authored-by: amigaire <94356747+amigaire@users.noreply.github.com> Co-authored-by: Bryan Stéphan <85103635+BryanS29-akeneo@users.noreply.github.com> Co-authored-by: etiennekerbastard <42570470+etiennekerbastard@users.noreply.github.com> * GRF-96: Fix get id value * GRF-96: Fix coupling * GRF-358 : Fix routing declaration (#18311) * Grf 289 fix event propagation after changing style applying (#18310) * GRF-289 : Fix event propagation on action button click * GRF-289 : Fix event propagation on action button click * GRF-551 : Replace local selection by the catalog local (#18317) * GRF-552 : Hide the description settings panel on view template (#18320) * GRF-552 : Hide the description settings panel on view template * GRF-552 : Delete comments that prepare GRF-556 * Update visual tests for branch GRF-551 (#18318) * GRF-551 : Replace local selection by the catalog local * Update visual tests for branch GRF-551 Co-authored-by: jeremy-beaucousin <jeremy.beaucousin@akeneo.com> Co-authored-by: jeremyBeaucousinAkeneo <jeremyBeaucousinAkeneo@users.noreply.github.com> * Update visual tests for branch GRF-96-release (#18314) Co-authored-by: jeremyBeaucousinAkeneo <jeremyBeaucousinAkeneo@users.noreply.github.com> * Update visual tests for branch GRF-289-FIX (#18312) * GRF-289 : Fix event propagation on action button click * GRF-289 : Fix event propagation on action button click * Update visual tests for branch GRF-289-FIX Co-authored-by: jeremy-beaucousin <jeremy.beaucousin@akeneo.com> Co-authored-by: jeremyBeaucousinAkeneo <jeremyBeaucousinAkeneo@users.noreply.github.com> * GRF-559 : Delete Activate template button on category tree page (#18325) * GRF-560: Sync category edition page locale with Products pages (#18330) * GRF-96: Fix test Co-authored-by: jeremy-beaucousin <jeremy.beaucousin@akeneo.com> Co-authored-by: Adrien Migaire <adrien.migaire@akeneo.com> Co-authored-by: etiennekerbastard <42570470+etiennekerbastard@users.noreply.github.com> Co-authored-by: amigaire <94356747+amigaire@users.noreply.github.com> Co-authored-by: jeremyBeaucousinAkeneo <114410848+jeremyBeaucousinAkeneo@users.noreply.github.com> Co-authored-by: etienne-kerbastard <etienne.kerbastard@akeneo.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: jeremyBeaucousinAkeneo <jeremyBeaucousinAkeneo@users.noreply.github.com>
tseho
pushed a commit
that referenced
this pull request
Aug 25, 2023
tseho
pushed a commit
that referenced
this pull request
Aug 25, 2023
tseho
pushed a commit
that referenced
this pull request
Aug 25, 2023
tseho
pushed a commit
that referenced
this pull request
Aug 25, 2023
tseho
pushed a commit
that referenced
this pull request
Aug 30, 2023
tseho
pushed a commit
that referenced
this pull request
Aug 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (for Contributor and Core Developer)
Definition Of Done (for Core Developer only)