Grf 361 create category template in database #18169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amigaire
commented
Oct 20, 2022
src/Akeneo/Category/back/Infrastructure/Storage/Save/Query/SqlTemplateRepository.php
Outdated
Show resolved
Hide resolved
amigaire
commented
Oct 20, 2022
src/Akeneo/Category/back/Application/Template/CreateTemplate.php
Outdated
Show resolved
Hide resolved
amigaire
added
echoes/intent: feature
src/Akeneo/Category/back/Infrastructure/Storage/Sql/IsCategoryTreeLinkedToTemplateSql.php
Outdated
Show resolved
Hide resolved
src/Akeneo/Category/back/Infrastructure/Storage/Save/Query/SqlCategoryTreeTemplateSaver.php
Outdated
Show resolved
Hide resolved
amigaire
force-pushed
the
GRF-361
branch
2 times, most recently
from
0b55eba
to
ef0a741
Compare
BryanS29-akeneo
approved these changes
Oct 25, 2022
src/Akeneo/Category/back/Infrastructure/Storage/Sql/GetCategoryTreeByCategoryTemplateSql.php
Outdated
Show resolved
Hide resolved
antoinetrouve
approved these changes
Oct 26, 2022
src/Akeneo/Category/back/Infrastructure/Storage/InMemory/GetTemplateInMemory.php
Outdated
Show resolved
Hide resolved
src/Akeneo/Category/back/Infrastructure/Storage/InMemory/GetTemplateInMemory.php
Outdated
Show resolved
Hide resolved
...Akeneo/Category/back/Infrastructure/Storage/Save/Query/SqlCategoryTemplateAttributeSaver.php
Outdated
Show resolved
Hide resolved
...Akeneo/Category/back/Infrastructure/Storage/Save/Query/SqlCategoryTemplateAttributeSaver.php
Outdated
Show resolved
Hide resolved
src/Akeneo/Category/back/Infrastructure/Storage/Save/Query/SqlCategoryTemplateSaver.php
Outdated
Show resolved
Hide resolved
src/Akeneo/Category/back/Infrastructure/Storage/Sql/GetCategoryTreeByCategoryTemplateSql.php
Show resolved
Hide resolved
src/Akeneo/Category/back/tests/Integration/CategoryTemplateTrait.php
Outdated
Show resolved
Hide resolved
amigaire
commented
Oct 26, 2022
...Akeneo/Category/back/Infrastructure/Storage/Save/Query/SqlCategoryTemplateAttributeSaver.php
Show resolved
Hide resolved
amigaire
commented
Oct 26, 2022
| $template =null; | ||
| if ($result) { | ||
| $template = new Template( | ||
| TemplateUuid::fromString($result['uuid']), |
There was a problem hiding this comment.
Create a Template::fromDatabase(array $result)
amigaire
commented
Oct 26, 2022
src/Akeneo/Category/back/Infrastructure/Storage/Sql/GetCategoryTemplateSql.php
Outdated
Show resolved
Hide resolved
amigaire
commented
Oct 26, 2022
src/Akeneo/Category/back/Infrastructure/Storage/Sql/GetCategoryTreeByCategoryTemplateSql.php
Show resolved
Hide resolved
amigaire
commented
Oct 26, 2022
src/Akeneo/Category/back/Infrastructure/Symfony/Resources/config/queries.yml
Show resolved
Hide resolved
amigaire
commented
Oct 26, 2022
src/Akeneo/Category/back/tests/Integration/CategoryTemplateTrait.php
Outdated
Show resolved
Hide resolved
amigaire
commented
Oct 26, 2022
src/Akeneo/Category/back/tests/Integration/CategoryTemplateTrait.php
Outdated
Show resolved
Hide resolved
amigaire
commented
Oct 26, 2022
| // TODO: activate SQL service instead of inMemory service in dependencies injection when GetTemplate->byUuid is implemented | ||
| $template = $this->get(GetTemplate::class)->byUuid((string) $templateModel->getUuid()); | ||
|
|
||
| $this->assertEquals($templateModel->getCode(), $template->getCode()); |
There was a problem hiding this comment.
create $expectedCode and use it with hadr coded value
same for labels, etc. (check toArray())
There was a problem hiding this comment.
amigaire
commented
Oct 26, 2022
| array_keys($template->getAttributeCollection()->getAttributes()), | ||
| ); | ||
| } | ||
|
|
There was a problem hiding this comment.
ajouter les tests de cas à la marge
amigaire
force-pushed
the
GRF-361
branch
3 times, most recently
from
2590e36
to
f7a7be8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (for Contributor and Core Developer)
[WIP] The migration to create tables related to category template and attributes are not merged yet (GRF-357)
Definition Of Done (for Core Developer only)