GRF-509 add service to generate template Model #18140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antoinetrouve
approved these changes
Oct 18, 2022
src/Akeneo/Category/back/Infrastructure/Builder/TemplateBuilder.php
Outdated
Show resolved
Hide resolved
src/Akeneo/Category/back/Infrastructure/Builder/TemplateBuilder.php
Outdated
Show resolved
Hide resolved
src/Akeneo/Category/back/Infrastructure/Builder/TemplateBuilder.php
Outdated
Show resolved
Hide resolved
src/Akeneo/Category/back/tests/Specification/Infrastructure/Builder/TemplateBuilderSpec.php
Show resolved
Hide resolved
BryanS29-akeneo
approved these changes
Oct 18, 2022
src/Akeneo/Category/back/Infrastructure/Builder/TemplateBuilder.php
Outdated
Show resolved
Hide resolved
| CategoryId $categoryId | ||
| ) | ||
| { | ||
| $searchingCategoryCode->__toString()->willReturn('category_code'); |
There was a problem hiding this comment.
In this case, it could be simpler to use directly the instance of the Code values object instead of using mocks. Moreover, all validation or business rules will be available
Suggested change
| $searchingCategoryCode->__toString()->willReturn('category_code'); | |
| const $searchingCategoryCode = new Code('category_code'); |
There was a problem hiding this comment.
It simplified a lot the tests, thx
etiennekerbastard
approved these changes
Oct 18, 2022
olivierpontier
approved these changes
Oct 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Service to generate a template based on a category tree's code.
The code and the label of the template are automatically generated, the label is only generated in english.
Description (for Contributor and Core Developer)
Definition Of Done (for Core Developer only)