GRF-234: value_collection in the Category model #17644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/Akeneo/Category/back/Infrastructure/Symfony/Resources/config/queries.yml
# Conflicts: # src/Akeneo/Category/back/Infrastructure/Storage/Sql/GetCategorySql.php # src/Akeneo/Category/back/tests/Integration/Infrastructure/Storage/Sql/GetCategorySqlIntegration.php
antoinetrouve
approved these changes
Aug 12, 2022
src/Akeneo/Category/back/Infrastructure/Storage/Sql/GetCategorySql.php
Outdated
Show resolved
Hide resolved
src/Akeneo/Category/back/Infrastructure/Storage/Sql/GetCategorySql.php
Outdated
Show resolved
Hide resolved
...neo/Category/back/tests/Integration/Infrastructure/Storage/Sql/GetCategorySqlIntegration.php
Show resolved
Hide resolved
etiennekerbastard
approved these changes
Aug 12, 2022
src/Akeneo/Category/back/Domain/ValueObject/PermissionCollection.php
Outdated
Show resolved
Hide resolved
src/Akeneo/Category/back/Domain/ValueObject/ValueCollection.php
Outdated
Show resolved
Hide resolved
StevenVAIDIE
pushed a commit
that referenced
this pull request
Aug 17, 2022
* GRF-234: Query to retrieve category information * GRF-234: Fix query * GRF-234: Fix query * GRF-234: Fix query * GRF-234: integration test * GRF-234: Add assertion on en_US * GRF-234: Assemble GetCategory byId and byCode * GRF-234: value_collection in the Category model * GRF-234: CamelCase on Sql * GRF-234: Rename GetCategory to GetCategorySql * GRF-234: wip * GRF-234: fix * GRF-234: Test on value_collection * GRF-234: Get category permissions * GRF-234: Fix permissions & CTE for translations * GRF-234: Remove useless use * GRF-234: Simplify integration tests + return null when it does not retrieve the category * GRF-234: Fix * GRF-234: Fix * GRF-234: Fix * GRF-234: Fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (for Contributor and Core Developer)
Retrieve value_collection from category table and format it in ValueCollection.
Definition Of Done (for Core Developer only)