Temporary CI fix: use phpunit's executable instead of composer one for onboarder tests #16066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahocquard
approved these changes
Dec 24, 2021
StevenVAIDIE
approved these changes
Dec 24, 2021
cha-ser
approved these changes
Dec 24, 2021
mmetayer
force-pushed
the
temporary-fix-for-CI
branch
from
7eb1a08
to
54179f8
Compare
…r onboarder tests
mmetayer
force-pushed
the
temporary-fix-for-CI
branch
from
54179f8
to
6087c18
Compare
mmetayer
commented
Dec 24, 2021
| @@ -298,7 +298,7 @@ jobs: | |||
| rm -f docker-compose.override.yml | |||
| PIM_VERSION=master SETUP_FOR_CI=1 PIM_CONTEXT=onboarder make setup-onboarder-parameters | |||
| PIM_VERSION=master PIM_CONTEXT=onboarder make setup-onboarder-tests | |||
| docker-compose run --rm php php /usr/local/bin/composer dumpautoload | |||
| docker-compose run --rm php php /usr/local/bin/composer dumpautoload --no-interaction | |||
There was a problem hiding this comment.
this also caused the build to fail (since the release of composer v2.2.0), it should not be reverted 🙂
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (for Contributor and Core Developer)
See sebastianbergmann/phpunit#4847.
This fix should be reverted as soon as either PHPUnit 9.5.11 or composer 2.2.2 is released.
Definition Of Done (for Core Developer only)