Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependency rollup to v3 #410

Merged
merged 2 commits into from
Nov 9, 2022
Merged

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Oct 11, 2022

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
rollup (source) ^2.75.7 -> ^3.0.0 age adoption passing confidence

Configuration

📅 Schedule: Branch creation - "after 10pm every weekday,before 5am every weekday,every weekend" in timezone Asia/Tokyo, Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Renovate will not automatically rebase this PR, because other commits have been found.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate
Copy link
Contributor Author

renovate bot commented Oct 11, 2022

⚠ Artifact update problem

Renovate failed to update an artifact related to this branch. You probably do not want to merge this PR as-is.

♻ Renovate will retry this branch, including artifacts, only when one of the following happens:

  • any of the package files in this branch needs updating, or
  • the branch becomes conflicted, or
  • you click the rebase/retry checkbox if found above, or
  • you rename this PR's title to start with "rebase!" to trigger it manually

The artifact failure details are included below:

File name: package-lock.json
npm ERR! code ERESOLVE
npm ERR! ERESOLVE could not resolve
npm ERR! 
npm ERR! While resolving: rollup-plugin-terser@7.0.2
npm ERR! Found: rollup@3.0.0
npm ERR! node_modules/rollup
npm ERR!   dev rollup@"^3.0.0" from the root project
npm ERR!   peer rollup@">=1.12.0" from rollup-plugin-commonjs@10.1.0
npm ERR!   node_modules/rollup-plugin-commonjs
npm ERR!     dev rollup-plugin-commonjs@"^10.1.0" from the root project
npm ERR!   1 more (rollup-plugin-node-resolve)
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer rollup@"^2.0.0" from rollup-plugin-terser@7.0.2
npm ERR! node_modules/rollup-plugin-terser
npm ERR!   dev rollup-plugin-terser@"^7.0.2" from the root project
npm ERR! 
npm ERR! Conflicting peer dependency: rollup@2.79.1
npm ERR! node_modules/rollup
npm ERR!   peer rollup@"^2.0.0" from rollup-plugin-terser@7.0.2
npm ERR!   node_modules/rollup-plugin-terser
npm ERR!     dev rollup-plugin-terser@"^7.0.2" from the root project
npm ERR! 
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR! 
npm ERR! See /tmp/renovate-cache/others/npm/eresolve-report.txt for a full report.

npm ERR! A complete log of this run can be found in:
npm ERR!     /tmp/renovate-cache/others/npm/_logs/2022-10-11T19_02_04_730Z-debug-0.log

@renovate renovate bot added the dependencies Pull requests that update a dependency file label Oct 11, 2022
@@ -1,6 +1,6 @@
import resolve from "rollup-plugin-node-resolve";
import commonjs from "rollup-plugin-commonjs";
import { terser } from "rollup-plugin-terser";
import { terser } from "rollup-plugin-minification";
Copy link
Contributor

@dera- dera- Nov 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rollup-plugin-terserモジュールが起因でコンフリクトが発生していたので別のモジュールを使うように変更しました。この修正はこちらのissueを参考にしています。

@@ -38,7 +38,7 @@
"scripts": {
"prepare": "npm run build && npm run doc",
"build": "npm run clean && tsc -p ./ && npm run bundle && npm run format",
"bundle": "rollup -c rollup.config.js",
"bundle": "rollup -c rollup.config.js --bundleConfigAsCjs",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[!] RollupError: Node tried to load your configuration file as CommonJS even though it is likely an ES module. To resolve this, change the extension of your configuration to ".mjs", set "type": "module" in your package.json file or pass the "--bundleConfigAsCjs" flag.

ビルド時にこのようなエラーが出ていたので、configファイルをCommonJSとしてバンドルする--bundleConfigAsCjsオプションを追加しました。(これはv3以降に追加されたオプションなので、v3以前は指定しなくてもCommonJSとしてバンドルされていた?)

@dera- dera- merged commit e0044ba into main Nov 9, 2022
@dera- dera- deleted the renovate/rollup-3.x branch November 9, 2022 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant