Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace uri-js with fast-uri #2415

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

vixalien
Copy link

@vixalien vixalien commented Apr 13, 2024

What issue does this pull request resolve?

This PR fixes issues #2350 and #2343. It removes the (deep) dependency on punycode, a deprecated module.

What changes did you make?

I replaced the default uriResolver to fast-uri instead of uri-js.

Is there anything that requires more attention while reviewing?

This PR supersedes #2377.

It is also worth considering using the web API URL which is defined in URL Living Standard instead of URI which is defined in RFC 3986 and is less prevalent and can resolve the issue raised by @jasoniangreen in the above linked PR:

...I have been speaking to @epoberezkin and he wants me to explore removing uri-js. [..] there is just an open question around browser support. I will update you when I have more.

We can use the native URL API as it is supported with node 10+ and all major browsers and it has 97.68% caniuse score while URI is not standardized afaict.

Thanks!

TODO:

@mbtools
Copy link

mbtools commented Apr 27, 2024

ajv is a major contributor to the [DEP0040] DeprecationWarning: The punycode module is deprecated issue that is popping up everywhere (since it's used in eslint). Please fix this.

Less dependencies. Better performance. This is the way!

@vixalien
Copy link
Author

I would be very happy if there were an initial review or at least a comment from the AJV team.

@tianyingchun
Copy link

how progress of this?

@tianyingchun
Copy link

@epoberezkin

@tianyingchun
Copy link

how progress of this?

@vixalien
Copy link
Author

vixalien commented May 9, 2024

No feedback from maintainers, can't move forward :(

@tianyingchun
Copy link

I see that there is still a version of this library released recently,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants