Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issue does this pull request resolve?
This PR fixes issues #2350 and #2343. It removes the (deep) dependency on
punycode
, a deprecated module.What changes did you make?
I replaced the default uriResolver to fast-uri instead of uri-js.
Is there anything that requires more attention while reviewing?
This PR supersedes #2377.
It is also worth considering using the web API
URL
which is defined in URL Living Standard instead ofURI
which is defined in RFC 3986 and is less prevalent and can resolve the issue raised by @jasoniangreen in the above linked PR:We can use the native
URL
API as it is supported with node 10+ and all major browsers and it has 97.68% caniuse score whileURI
is not standardized afaict.Thanks!
TODO: