Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update typescript to 5.3.3 #2406

Merged
merged 2 commits into from Apr 27, 2024
Merged

chore: update typescript to 5.3.3 #2406

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8f3b729
chore: update typescript to 5.3.3
jasoniangreen Apr 5, 2024
12bfffa
test: result should always be a Promise
jasoniangreen Apr 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Expand Up @@ -104,7 +104,7 @@
"rollup-plugin-terser": "^7.0.2",
"ts-node": "^10.9.2",
"tsify": "^5.0.4",
"typescript": "^4.9.5"
"typescript": "5.3.3"
},
"collective": {
"type": "opencollective",
Expand Down
6 changes: 3 additions & 3 deletions spec/types/async-validate.spec.ts
View file
Open in desktop
Expand Up @@ -109,10 +109,10 @@ describe("$async validation and type guards", () => {
const data: unknown = {foo: 1}
let result: boolean | Promise<Foo>
if ((result = validate(data))) {
if (typeof result == "boolean") {
data.foo.should.equal(1)
} else {
if (result instanceof Promise) {
await result.then((_data) => _data.foo.should.equal(1))
} else {
should.fail()
}
} else {
should.fail()
Expand Down