Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support for arrays of mergeable objects in the “with” argument of “$merge” #15

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

azaslavsky
Copy link

This is a working implementation of the feature proposed in #14. It would also close #12.

@coveralls
Copy link

coveralls commented Oct 10, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling e84920a on azaslavsky:arrays-for-with into d847ec3 on epoberezkin:master.

@epoberezkin
Copy link
Member

@azaslavsky Thank you, I will review

@vganapat
Copy link

Hello, I was looking for the fix to #12 and was wondering, is there an update on the PR review?

@epoberezkin
Copy link
Member

The fix to #12 is very simple, there is a separate PR for that. To support an array instead of a simple schema, there is no need to change the package completely. Instead of passing "json-merge-patch" package as is, you just need to pass a wrapper around this package that understands arrays.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants