Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: account for this.popup being potentially undefined in completion mousewheel listener #5537

Merged
merged 14 commits into from
Apr 23, 2024

Conversation

akoreman
Copy link
Contributor

Issue #, if available: NA

Description of changes: When using completion, a mousewheel listener is attached to close the popup on scroll. In some circumstances, this.popup can be undefined causing errors to be thrown and scrolling to break. This change accounts for this.popup being possibly undefined here.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Pull Request Checklist:

Copy link

codecov bot commented Apr 23, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 86.64%. Comparing base (7869158) to head (01abcfa).

Files Patch % Lines
src/autocomplete.js 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5537   +/-   ##
=======================================
  Coverage   86.64%   86.64%           
=======================================
  Files         593      593           
  Lines       42839    42839           
  Branches     7120     7120           
=======================================
  Hits        37117    37117           
  Misses       5722     5722           
Flag Coverage Δ
unittests 86.64% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@akoreman akoreman merged commit 6c3a9a6 into ajaxorg:master Apr 23, 2024
2 of 3 checks passed
@akoreman akoreman deleted the mousewheel_fix branch April 23, 2024 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants