Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Folding for comments and different modes #5533

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

mkslanc
Copy link
Contributor

@mkslanc mkslanc commented Apr 15, 2024

Issue #, if available: #5521

Description of changes:

  • Fixed missing Array state handling in getCommentFoldRange.
  • Corrected comment fold range determination in XML languages (now getFoldRange won't return the next tag after a comment).
  • Improved documentation comments regular expression to handle the /**/ case.
  • Fixed Lua comment and string folding range.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Pull Request Checklist:

Copy link

codecov bot commented Apr 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.72%. Comparing base (7869158) to head (5b0fa5e).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5533      +/-   ##
==========================================
+ Coverage   86.64%   86.72%   +0.08%     
==========================================
  Files         593      594       +1     
  Lines       42839    42876      +37     
  Branches     7120     7120              
==========================================
+ Hits        37117    37186      +69     
+ Misses       5722     5690      -32     
Flag Coverage Δ
unittests 86.72% <100.00%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant