Fix: make RTL new line a valid character #5434
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We create a mechanism for specifying valid control characters. In this way, we can set wished behaviors, without making RTL mode less secure.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #5434 +/- ##
==========================================
- Coverage 87.59% 87.58% -0.01%
==========================================
Files 584 584
Lines 46408 46411 +3
Branches 7021 7021
==========================================
+ Hits 40650 40651 +1
- Misses 5758 5760 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
oykuyilmaz
approved these changes
Dec 28, 2023
|
Should we add a test covering this new behaviour? |
|
Would it be better to just skip the first character if it is rtl mark and keep 5he old code for the rest? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #5423
Description of changes:
We create a mechanism for specifying valid control characters. In this way, we can set wished behaviors, without making RTL mode less secure.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.