Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate dts generator for ace-code and ace-builds #5427

Open
wants to merge 17 commits into
base: master
Choose a base branch
from

Conversation

mkslanc
Copy link
Contributor

@mkslanc mkslanc commented Dec 15, 2023

Issue #, if available:

Description of changes:
This pull request introduces changes that enable the generation of a comprehensive TypeScript declaration file, designed to be utilized as a public API. These modifications ensure that the generated declaration file accurately reflects the structure of both ace-builds and ace-code packages, providing a seamless integration for developers.

Key Features:

  • Unified Declaration: Consolidates type definitions across ace-builds and ace-code, facilitating easier maintenance and usage.
  • Project Structure Compliance: Adheres to the respective project structures, ensuring that the generated file is both accurate and functional.
  • All internal statements (started with $ or marked as private) would be filtered from final decalration

Disclaimer: For ace-builds, all internal module paths are modified to follow the ace-builds-internal/module structure, which could be used as completion items in IDE's.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link

github-actions bot commented Apr 8, 2024

One of the public type files has been updated, plase make sure there are no backwards incompatible changes done in the PR.

Copy link

github-actions bot commented Apr 8, 2024

One of the public type files has been updated, plase make sure there are no backwards incompatible changes done in the PR.

Copy link

One of the public type files has been updated, plase make sure there are no backwards incompatible changes done in the PR.

Copy link

One of the public type files has been updated, plase make sure there are no backwards incompatible changes done in the PR.

1 similar comment
Copy link

One of the public type files has been updated, plase make sure there are no backwards incompatible changes done in the PR.

Copy link

One of the public type files has been updated, plase make sure there are no backwards incompatible changes done in the PR.

Copy link

One of the public type files has been updated, plase make sure there are no backwards incompatible changes done in the PR.

Copy link

One of the public type files has been updated, plase make sure there are no backwards incompatible changes done in the PR.

Copy link

One of the public type files has been updated, plase make sure there are no backwards incompatible changes done in the PR.

Copy link

One of the public type files has been updated, plase make sure there are no backwards incompatible changes done in the PR.

Copy link

One of the public type files has been updated, plase make sure there are no backwards incompatible changes done in the PR.

Copy link

One of the public type files has been updated, plase make sure there are no backwards incompatible changes done in the PR.

Copy link

One of the public type files has been updated, plase make sure there are no backwards incompatible changes done in the PR.

Copy link

codecov bot commented Apr 18, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 86.64%. Comparing base (7869158) to head (bb9b63b).

Files Patch % Lines
src/autocomplete.js 76.92% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5427   +/-   ##
=======================================
  Coverage   86.64%   86.64%           
=======================================
  Files         593      593           
  Lines       42839    42840    +1     
  Branches     7120     7120           
=======================================
+ Hits        37117    37118    +1     
  Misses       5722     5722           
Flag Coverage Δ
unittests 86.64% <80.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nightwing nightwing marked this pull request as ready for review April 21, 2024 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants