Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixed handling surrogare characters in insert, replace, delete mode in Vim #4934

Merged
merged 2 commits into from Sep 24, 2022

Conversation

andrewnester
Copy link
Contributor

Issue #, if available: #4108

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov
Copy link

codecov bot commented Sep 23, 2022

Codecov Report

Base: 85.96% // Head: 85.99% // Increases project coverage by +0.03% 🎉

Coverage data is based on head (38f893a) compared to base (357fcf5).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4934      +/-   ##
==========================================
+ Coverage   85.96%   85.99%   +0.03%     
==========================================
  Files         542      542              
  Lines       41398    41451      +53     
  Branches     6552     6554       +2     
==========================================
+ Hits        35587    35645      +58     
+ Misses       5811     5806       -5     
Flag Coverage Δ
unittests 85.99% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/keyboard/vim.js 89.82% <100.00%> (+0.13%) ⬆️
src/keyboard/vim_test.js 98.60% <100.00%> (+0.01%) ⬆️
src/edit_session.js 85.76% <0.00%> (+0.08%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@nightwing nightwing merged commit e281200 into ajaxorg:master Sep 24, 2022
@andrewnester andrewnester deleted the vim-emoji branch September 24, 2022 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants