[#1217] Make validation work for auth app (#1225)

Fixes #1217

BUILD

@@ -101,6 +101,7 @@ java_library(
     exports = [
         "@maven//:javax_servlet_javax_servlet_api",
         "@maven//:javax_validation_validation_api",
+        "@maven//:org_hibernate_validator_hibernate_validator",
         "@maven//:org_springframework_boot_spring_boot",
         "@maven//:org_springframework_boot_spring_boot_autoconfigure",
         "@maven//:org_springframework_boot_spring_boot_loader",

backend/api/auth/src/main/java/co/airy/core/api/auth/controllers/payload/SignupRequestPayload.java

@@ -1,16 +1,12 @@
 package co.airy.core.api.auth.controllers.payload;
 
-import lombok.AllArgsConstructor;
-import lombok.Builder;
 import lombok.Data;
 import lombok.NoArgsConstructor;
 
 import javax.validation.constraints.NotBlank;
 
 @Data
-@Builder
 @NoArgsConstructor
-@AllArgsConstructor
 public class SignupRequestPayload {
     @NotBlank
     private String email;

backend/api/auth/src/test/java/co/airy/core/api/auth/UsersControllerTest.java

@@ -105,15 +105,26 @@ void canSignupAndLogin() throws Exception {
     }
 
     @Test
-    void canRestPassword() throws Exception {
+    void canValidateSignup() throws Exception {
+        final String firstName = "grace";
+        final String email = "grace@example.com";
+        final String password = "trustno1";
+
+        final String signUpRequest = "{\"email\":\"" + email + "\",\"first_name\":\"" + firstName + "\",\"password\":\"" + password + "\"}";
+
+        webTestHelper.post("/users.signup", signUpRequest).andExpect(status().isBadRequest());
+    }
+
+    @Test
+    void canResetPassword() throws Exception {
         final String email = "ada@example.com";
 
         final String signUpRequest = "{\"email\":\"" + email + "\",\"first_name\":\"something\"," +
                 "\"last_name\":\"hopper\",\"password\":\"trustno1\"}";
 
         webTestHelper.post("/users.signup", signUpRequest).andExpect(status().isOk());
 
-        final String passwordResetRequest = "{\"email\":\"" + email + "\"}";
+        final String passwordResetRequest = "{\"email\":\"" + email + "\",\"password\":\"trustno1\"}";
 
         doNothing().when(mail).send(Mockito.eq(email), anyString(), anyString());
 
@@ -186,7 +197,7 @@ void canChangePassword() throws Exception {
         final JsonNode jsonNode = objectMapper.readTree(signupResponse);
         final String userId = jsonNode.get("id").textValue();
 
-        final String requestPasswordRequest = "{\"email\":\"" + email + "\"}";
+        final String requestPasswordRequest = "{\"email\":\"" + email + "\", \"password\":\"trustno1\"}";
 
         doNothing().when(mail).send(Mockito.eq(email), anyString(), anyString());