Support dynamic properties in HTTP announcement #1157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
findepi
force-pushed
the
findepi/discovery-dyn
branch
from
cfede98
to
1a83fe6
Compare
wendigo
reviewed
May 6, 2024
discovery/src/main/java/io/airlift/discovery/client/DiscoveryBinder.java
Outdated
Show resolved
Hide resolved
electrum
reviewed
May 6, 2024
discovery/src/test/java/io/airlift/discovery/client/TestHttpAnnouncementBinder.java
Show resolved
Hide resolved
discovery/src/main/java/io/airlift/discovery/client/DiscoveryBinder.java
Outdated
Show resolved
Hide resolved
discovery/src/main/java/io/airlift/discovery/client/DiscoveryBinder.java
Outdated
Show resolved
Hide resolved
discovery/src/main/java/io/airlift/discovery/client/DiscoveryBinder.java
Outdated
Show resolved
Hide resolved
discovery/src/main/java/io/airlift/discovery/client/DiscoveryBinder.java
Outdated
Show resolved
Hide resolved
discovery/src/main/java/io/airlift/discovery/client/DiscoveryBinder.java
Show resolved
Hide resolved
findepi
force-pushed
the
findepi/discovery-dyn
branch
from
1a83fe6
to
84ca213
Compare
|
AC, PTAL |
electrum
approved these changes
May 6, 2024
There was a problem hiding this comment.
The API looks good, but we should still create custom annotation class rather than using Named. We avoid using Named as it's single shared namespace. While this usage of using it with UUIDs is unlikely to actually be a problem, using a custom annotation is best practice (and keeps the simple rule of "don't use Named").
|
Custom annotation is less encapsulated, as someone could instantiate it outside of the dedicated builder, so i think this usage of Named is actually better. We will need a custom annotation if we want idempotence (#1157 (comment)). Although I don't agree, I will still switch to custom annotation. |
Fix the test to test the class it is supposed to test.
Extend discovery binder's bindHttpAnnouncement's capabilities by allowing bindings of non-constant properties that require Guice injection to be calculated.
findepi
force-pushed
the
findepi/discovery-dyn
branch
from
84ca213
to
9034c7b
Compare
wendigo
reviewed
May 7, 2024
| @@ -0,0 +1,65 @@ | |||
| /* | |||
There was a problem hiding this comment.
Drop this header - not required.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extend discovery binder's bindHttpAnnouncement's capabilities by
allowing bindings of non-constant properties that require Guice
injection to be calculated.
For trinodb/trino#21744