Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't import User and Role FAB models, fixes airflow 2.9.0+ #857

Conversation

thesuperzapper
Copy link
Member

@thesuperzapper thesuperzapper commented Apr 30, 2024

What issues does your PR fix?

What does your PR do?

I give up, I have no idea why they keep moving the FAB User and Role models around, but we don't really need to import them anyway (they were only for type hints).

Checklist

For all Pull Requests

Signed-off-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com>
@thesuperzapper thesuperzapper added this to the airflow-8.9.0 milestone Apr 30, 2024
@thesuperzapper thesuperzapper added the status/ready-to-merge status - this will be merged into next release label May 1, 2024
@thesuperzapper thesuperzapper changed the title fix: stop importing User/Role FAB models, airflow keeps moving them fix: don't import User and Role FAB models, fixes airflow 2.9.0+ May 1, 2024
@thesuperzapper thesuperzapper merged commit 912a037 into airflow-helm:main May 1, 2024
3 checks passed
@thesuperzapper thesuperzapper deleted the stop-importing-user-role-models branch May 1, 2024 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/ready-to-merge status - this will be merged into next release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sync airflow.users does not work in airflow 2.9.0+
1 participant