Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add pgbouncer.statsUsers value to set stats_user in pgbouncer #820

Merged
merged 3 commits into from
May 1, 2024

Conversation

jbvaningen
Copy link
Contributor

@jbvaningen jbvaningen commented Feb 1, 2024

What issues does your PR fix?

What does your PR do?

This PR adds the following values:

  • pgbouncer.statsUsers (default: "")
    • Sets the stats_users PgBouncer config in the pgbouncer.ini file.

Checklist

For all Pull Requests

For releasing ONLY

Signed-off-by: jbvaningen <joost@dexterenergy.nl>
Signed-off-by: jbvaningen <joost@dexterenergy.nl>
@jbvaningen
Copy link
Contributor Author

@thesuperzapper are you or somebody else available to review this PR please?

Copy link

stale bot commented Apr 22, 2024

This issue has been automatically marked as stale because it has not had activity in 60 days.
It will be closed in 7 days if no further activity occurs.

Thank you for your contributions.


Issues never become stale if any of the following is true:

  1. they are added to a Project
  2. they are added to a Milestone
  3. they have the lifecycle/frozen label

@stale stale bot added the lifecycle/stale lifecycle - this is stale label Apr 22, 2024
@jbvaningen
Copy link
Contributor Author

@thesuperzapper we are still interested in getting this merged. Is anyone available to review this?

@stale stale bot removed the lifecycle/stale lifecycle - this is stale label Apr 22, 2024
@thesuperzapper
Copy link
Member

@jbvaningen sorry for missing this!

We are currently trying to get airflow 2.9 working in a new release, so I guess this could be part of that.

Is this single config really all you need?

Is there anything else we should add or another way of doing this?

@jbvaningen
Copy link
Contributor Author

@thesuperzapper nice!

yes this single config is all that is needed to support pgbouncer metrics exporting.

@thesuperzapper thesuperzapper added this to the airflow-8.9.0 milestone Apr 24, 2024
Signed-off-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com>
Copy link
Member

@thesuperzapper thesuperzapper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jbvaningen thanks, I pushed a small cosmetic update in d43bbf3, but this is good to merge.

@thesuperzapper thesuperzapper added the status/ready-to-merge status - this will be merged into next release label Apr 29, 2024
@thesuperzapper thesuperzapper changed the title feat: add stats_users configuration option for pgbouncer feat: add stats_users configuration option for pgbouncer Apr 29, 2024
@thesuperzapper thesuperzapper merged commit d645492 into airflow-helm:main May 1, 2024
3 checks passed
@thesuperzapper thesuperzapper changed the title feat: add stats_users configuration option for pgbouncer feat: add pgbouncer.statsUsers value to set stats_user in pgbouncer May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/ready-to-merge status - this will be merged into next release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable querying of PgBouncer metrics by supporting additional PgBouncer configuration
2 participants