Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add airflow.defaultContainerSecurityContext value #624

Merged
merged 3 commits into from
May 1, 2024

Conversation

zartstrom
Copy link
Contributor

@zartstrom zartstrom commented Jul 11, 2022

Signed-off-by: Philipp Hitzler philipp.hitzler@idealo.de

What issues does your PR fix?

What does your PR do?

This PR adds the following values:

@thesuperzapper all code is taken from your #578 (comment)

Checklist

For all Pull Requests

For releasing ONLY

Signed-off-by: Philipp Hitzler <philipp.hitzler@idealo.de>
Signed-off-by: Philipp Hitzler <philipp.hitzler@idealo.de>
@stale
Copy link

stale bot commented Sep 16, 2022

This issue has been automatically marked as stale because it has not had activity in 60 days.
It will be closed in 7 days if no further activity occurs.

Thank you for your contributions.


Issues never become stale if any of the following is true:

  1. they are added to a Project
  2. they are added to a Milestone
  3. they have the lifecycle/frozen label

@stale stale bot added the lifecycle/stale lifecycle - this is stale label Sep 16, 2022
@stale stale bot closed this Sep 24, 2022
@thesuperzapper thesuperzapper reopened this Feb 6, 2023
@thesuperzapper thesuperzapper added this to the airflow-8.7.0 milestone Feb 6, 2023
@thesuperzapper thesuperzapper added this to Unsorted in Issue Triage and PR Tracking via automation Feb 6, 2023
@thesuperzapper thesuperzapper moved this from Unsorted to PR | Needs Review in Issue Triage and PR Tracking Feb 6, 2023
@stale stale bot closed this Feb 18, 2023
Issue Triage and PR Tracking automation moved this from PR | Needs Review to Done Feb 18, 2023
@thesuperzapper thesuperzapper reopened this Apr 5, 2023
Issue Triage and PR Tracking automation moved this from Done to Unsorted Apr 5, 2023
@stale stale bot removed the lifecycle/stale lifecycle - this is stale label Apr 5, 2023
@kshekhar-outra
Copy link

seems like a good feature to use, will this approved?

Signed-off-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com>
@thesuperzapper thesuperzapper changed the title feat: add defaultContainerSecurityContext feat: add airflow.defaultContainerSecurityContext value Apr 29, 2024
Issue Triage and PR Tracking automation moved this from Unsorted to PR | Ready to Merge Apr 29, 2024
Copy link
Member

@thesuperzapper thesuperzapper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zartstrom sorry about the extreme delay on this, but thanks for the PR.

I have pushed a small cleanup in abe66e4.

But its otherwise good to go, and should be in version 8.9.0 of the chart!

@thesuperzapper thesuperzapper added the status/ready-to-merge status - this will be merged into next release label Apr 29, 2024
@thesuperzapper thesuperzapper merged commit 3b778fc into airflow-helm:main May 1, 2024
3 checks passed
Issue Triage and PR Tracking automation moved this from PR | Ready to Merge to Done May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/ready-to-merge status - this will be merged into next release
Development

Successfully merging this pull request may close these issues.

add airflow.defaultContainerSecurityContext value
3 participants