🚨 🚨 ✨ Source Tik Tok Marketing: Migration to Low-Code #38316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
octavia-squidington-iii
added
area/connectors
…pe for dimensions transformations
octavia-squidington-iii
added
the
area/documentation
darynaishchenko
changed the title
artem1205
reviewed
May 31, 2024
| else: | ||
| stream_state = stream_states[0] | ||
| kwargs = {"stream_state": stream_state, "stream_slice": stream_slice, "next_page_token": next_page_token} | ||
| return [record for record in records if self._filter_interpolator.eval(self.config, record=record, **kwargs)] |
There was a problem hiding this comment.
Please update to align with original signature (Iterable)
artem1205
reviewed
May 31, 2024
|
|
||
| requester: | ||
| type: HttpRequester | ||
| url_base: '{{ "https://sandbox-ads.tiktok.com/open_api/v1.3/" if config.get(''credentials'', {})[''auth_type''] == "sandbox_access_token" else "https://business-api.tiktok.com/open_api/v1.3/" }}' |
There was a problem hiding this comment.
Suggested change
| url_base: '{{ "https://sandbox-ads.tiktok.com/open_api/v1.3/" if config.get(''credentials'', {})[''auth_type''] == "sandbox_access_token" else "https://business-api.tiktok.com/open_api/v1.3/" }}' | |
| url_base: '"https://{{ "sandbox-ads" if config.get(''credentials'', {})[''auth_type''] == "sandbox_access_token" else "business-api" }}.tiktok.com/open_api/v1.3/"' |
nit
| type: DpathExtractor | ||
| field_path: ["data", "list"] | ||
|
|
||
| record_selector_with_filter_by_midify_time: |
There was a problem hiding this comment.
Suggested change
| record_selector_with_filter_by_midify_time: | |
| record_selector_with_filter_by_modify_time: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
resolved: https://github.com/airbytehq/airbyte-internal-issues/issues/7824
How
Migrated source to use low-code cdk instead of python cdk.
Main changes:
lifetime=trueas request param, which is deprecated on API v1.3. Now lifetime reports usequery_lifetime=true, with this param start_date and end_date should not be provided. Exception: advertiser_lifetime_report: API v1.3 doesn't allow query_lifetime=true` with advertiser reports, so this stream was implemented exactly as in py version with start_date and end_date query params(range >=365d)Review guide
User Impact
Breaking change users will need to follow migration guide for affected streams.
Can this PR be safely reverted and rolled back?
Breaking change due to changes in schema and state format.