Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python CDK: Relax pydantic version requirement #28854

Merged
merged 6 commits into from
Aug 2, 2023

Conversation

flash1293
Copy link
Contributor

@flash1293 flash1293 commented Jul 31, 2023

This PR relaxes the version requirement of pydantic for the CDK to make it easier to use libraries that don't work with 1.9.2

It's an updated version of #16172

As spec schemas are generated slightly differently, the CATs need to be adjusted. It's not allowed to specify default or enum on the common const property as long as they only repeat the const value. This works fine in the UI as it only checks the const property: https://github.com/airbytehq/airbyte-cloud/blob/18988f9e34cb245edcdf6c1f83d78e9b64b3d71d/oss/airbyte-webapp/src/core/form/schemaToFormBlock.ts#L75

and doesn't actually render any fields that have const set: https://github.com/airbytehq/airbyte-cloud/blob/bbb24e2f7d9525285e7a9ac73cf92b22e52ac480/oss/airbyte-webapp/src/views/Connector/ConnectorForm/components/Sections/FormSection.tsx#L33

@flash1293
Copy link
Contributor Author

This PR still needs to get its protocol version bumped to 0.3.7 once it's released: https://github.com/airbytehq/airbyte/pull/28854/files#diff-4447bde589c0143e4d0c6475e78f9e945e464223a6ea052c5a7f5ee973461ba1L53

@flash1293
Copy link
Contributor Author

Had to do some slight changes to handle the CDK and pydantic update

@flash1293
Copy link
Contributor Author

flash1293 commented Aug 2, 2023

/legacy-publish connector=bases/source-acceptance-test auto-bump-version=false

Error: Unexpected inputs provided: ["auto-bump-version"]

@flash1293
Copy link
Contributor Author

flash1293 commented Aug 2, 2023

/legacy-publish connector=bases/source-acceptance-test

🕑 Publishing the following connectors:
bases/source-acceptance-test
https://github.com/airbytehq/airbyte/actions/runs/5737690529


Connector Version Did it publish?
bases/source-acceptance-test

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@flash1293
Copy link
Contributor Author

flash1293 commented Aug 2, 2023

/legacy-publish connector=bases/connector-acceptance-test

🕑 Publishing the following connectors:
bases/connector-acceptance-test
https://github.com/airbytehq/airbyte/actions/runs/5737695052


Connector Version Did it publish?
bases/connector-acceptance-test

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@flash1293 flash1293 merged commit 60e1d72 into master Aug 2, 2023
29 checks passed
@flash1293 flash1293 deleted the flash1293/update-pydantic branch August 2, 2023 11:03
bnchrch pushed a commit that referenced this pull request Aug 3, 2023
* relax pydantic dep

* Automated Commit - Format and Process Resources Changes

* update protocol models

* format change

---------

Co-authored-by: flash1293 <flash1293@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants