New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable rescue alignment cop until bugs are fixed #168
Conversation
The solution here is to do this instead return_val =
begin
# computation
rescue
# rescued value
end |
The problem is more being caused by inconsistent lining up of en with begin block and the body. This isn't a bug but rather configuration |
True, but we'd like the option to have |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to this, it looks like there is a bug with the associated autocorrect
too: rubocop/rubocop#6254
I'm fine with disabling this until the cop is more stable.
I think the autocorrect bug is now fixed. I'm going to hold off on merging this for a little bit to see if the rubocop configuration change gets merged. If it seems like it will take a while, then I'll merge this to disable the cop. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ship it
Since we've progressed well past rubocop 0.9.1, I'm going to close this out. Thanks everyone for the contributions. |
Currently the rescue alignment cop has an issue on variable assignments where it enforces this style:
which is bad.
rubocop/rubocop#7531 will maybe fix it, but I think it makes sense to disable this for now until it's fixed in a rubocop release.