Additional detail regarding the use of map over collect #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
approved these changes
May 6, 2017
akuhn
reviewed
May 17, 2017
| @@ -1390,7 +1390,7 @@ In either case: | |||
| ## Collections | |||
|
|
|||
| * <a name="map-over-collect"></a>Prefer `map` over | |||
| `collect`.<sup>[[link](#map-over-collect)]</sup> | |||
| `collect` as it's a more recognized convention among programmers.<sup>[[link](#map-over-collect)]</sup> | |||
There was a problem hiding this comment.
Shouldn't we add the same comment for reduce then?
Also, it seems the consistency argument from the issue conversation is not mentioned here. Maybe we can say something like ... for consistency, and familiarity of terminology (eventhough the latter breaks my heart as a Smalltalker, sigh).
There was a problem hiding this comment.
Yes, we should use reduce over inject for the same reason imo.
shashankjo
approved these changes
Dec 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added additional detail to style guide regarding the use of map and collect.
Closes #101.