Adds Hilt Example (Dagger @AssistedInject edition) #495
Conversation
|
|
||
| // module/build.gradle | ||
| ```groovy | ||
| repositories { |
There was a problem hiding this comment.
I believe putting this in the top level build.gradle file like:
allprojects {
repositories {
...
}
}
would be more standard
|
|
||
| * **Injecting state into ViewModels with AssistedInject** | ||
|
|
||
| Since the `initialState` parameter is only available at runtime, Dagger can not provide this dependency for us. We need the [AssistedInject](https://github.com/square/AssistedInject) library for this purpose. |
There was a problem hiding this comment.
Oh dam, totally missed this. Yep
| ```kotlin | ||
| interface AppModule { | ||
|
|
||
| @[Binds IntoMap ViewModelKey(MyViewModel::class)] |
There was a problem hiding this comment.
Interesting syntax. I've never seen the annotation array like this before! Good to know it's possible but I think it'll be easier for people to understand if you split it into 3 lines because that syntax is more common.
|
|
||
| ## How it works | ||
|
|
||
| `HiltMavericksViewModelFactory` will try loading the custom entry point from the `SingletonComponent` |
There was a problem hiding this comment.
What if you wanted this to be scoped to a different component? This should theoretically be able to be scoped by Fragment, Activity, ActivityRetained, or Singleton right?
There was a problem hiding this comment.
I was thinking about that. It should be as simple as creating a custom @EntryPoint for each scope and adding @Qualifier to the ViewModel's to split them into each scope… I think
| @@ -0,0 +1,51 @@ | |||
| apply plugin: "com.android.application" | |||
| apply plugin: "kotlin-android" | |||
| apply plugin: "kotlin-android-extensions" | |||
There was a problem hiding this comment.
kotlin-android-extensions is deprecated now. Let's move to the parcelize plugin for all new things and we can remove it from the rest soon.
There was a problem hiding this comment.
Ah, yep. Did not see that.
|
|
||
| debugImplementation Libraries.fragmentTesting | ||
|
|
||
| androidTestImplementation InstrumentedTestLibraries.core |
| val viewModel: HelloViewModel by fragmentViewModel() | ||
|
|
||
| override fun onViewCreated(view: View, savedInstanceState: Bundle?) { | ||
| helloButton.setOnClickListener { viewModel.sayHello() } |
There was a problem hiding this comment.
Can you migrate this to view binding like the sample app? You can copy in FragmentViewBindingDelegate
| fun sayHello(): Observable<String> { | ||
| return Observable | ||
| .just("Hello, world!") | ||
| .delay(2, TimeUnit.SECONDS) | ||
| } |
There was a problem hiding this comment.
Can you make this coroutines since most new things will be using that? It can be:
| fun sayHello(): Observable<String> { | |
| return Observable | |
| .just("Hello, world!") | |
| .delay(2, TimeUnit.SECONDS) | |
| } | |
| suspend fun sayHello()String { | |
| delay(2_000) | |
| return "Hello World" | |
| } |
| } | ||
|
|
||
| fun sayHello() { | ||
| repo.sayHello().execute { copy(message = it) } |
There was a problem hiding this comment.
| repo.sayHello().execute { copy(message = it) } | |
| suspend { repo.sayHello() }.execute { copy(message = it) } |
| @InstallIn(SingletonComponent::class) | ||
| interface AppModule { | ||
|
|
||
| @[Binds IntoMap ViewModelKey(HelloViewModel::class)] |
There was a problem hiding this comment.
Can you split this into 3 lines (see comment in README)
This PR is a heavily modified #495 MavericksViewModels no longer extend Jetpack ViewModels. However, we want to make sure that we have a story for how to use it with Hilt and its new @ViewModelScoped scope. I couldn't figure out how to integrate Mavericks with its corresponding ViewModelComponent. However, I was able to create the same setup with a custom component instead. It achieves the same thing and I can't think of any downsides.
|
Closing in favour of #503 |
Dagger Hilt snapshot release added
@AssistedInject. So, I rebased the branch from @carlosmuvi #420 onto master and updated dagger to use the snapshot@AssistedInject.As per #420 PR the new module adds an Hilt app module.
Differences vs Vanilla Dagger sample
The application now includes @HiltAndroidApp.
AppComponent has been removed, and existing modules are now installed in Hilt's
SingletonComponent.An
@EntryPointreplaces AppComponent#viewModelFactories.