Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Compose] Add safeMode #2455

Merged
merged 2 commits into from Jan 30, 2024
Merged

[Compose] Add safeMode #2455

merged 2 commits into from Jan 30, 2024

Conversation

kunal-jar
Copy link
Contributor

This allows to use the safeModeApi in LottieAnimation for compose

Fixes #2452

@@ -88,6 +90,7 @@ fun LottieAnimation(
clipTextToBoundingBox: Boolean = false,
fontMap: Map<String, Typeface>? = null,
asyncUpdates: AsyncUpdates = AsyncUpdates.AUTOMATIC,
isSafeMode: Boolean = false,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
isSafeMode: Boolean = false,
safeMode: Boolean = false,

Let's remove is to be consistent with the other boolean names here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gpeal done

Copy link

Snapshot Tests
API 23: Report Diff
API 31: Report Diff

Copy link

Snapshot Tests
API 23: Report Diff
API 31: Report Diff

@gpeal gpeal changed the title Add safeMode in compose LottieAnimation [Compose] Add safeMode Jan 30, 2024
@gpeal gpeal merged commit 8b8c22b into airbnb:master Jan 30, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lottie JNI Crashes on play store deployed app
2 participants