Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow for non-closing input stream parsing #2286

Merged
merged 1 commit into from May 7, 2023
Merged

Allow for non-closing input stream parsing #2286

merged 1 commit into from May 7, 2023

Conversation

gpeal
Copy link
Collaborator

@gpeal gpeal commented May 7, 2023

Fixes #2252

@github-actions
Copy link

github-actions bot commented May 7, 2023

Snapshot Tests
API 23: Report Diff
API 31: Report Diff

@gpeal gpeal merged commit cb2c4d5 into master May 7, 2023
6 checks passed
@gpeal gpeal deleted the gpeal/input-stream-close-public branch May 7, 2023 18:44
@peerless2012
Copy link
Contributor

Zip InputStream still not support control close or not.

@gpeal
Copy link
Collaborator Author

gpeal commented May 8, 2023

Is that something you're using as well?

@peerless2012
Copy link
Contributor

Yes, ZipInputStream need controll close for user.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Request LottieCompositionFactory fromXXXInputStream close param to be public.
2 participants
@gpeal @peerless2012