Fix LottieDrawable#start for non-View callbacks #2056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the start function would be a noop if your callback was something other than a View instance.
gpeal
reviewed
Apr 13, 2022
| @@ -551,7 +551,7 @@ public void draw(Canvas canvas, Matrix matrix) { | |||
| public void start() { | |||
| // Don't auto play when in edit mode. | |||
| Callback callback = getCallback(); | |||
| if (callback instanceof View && !((View) callback).isInEditMode()) { | |||
| if (!(callback instanceof View) || !((View) callback).isInEditMode()) { | |||
There was a problem hiding this comment.
Thinking about this a bit more, it might be easier to read as if (is View && isInEditMode() return
The double negative with an or requires too much thought to grok 😄
gpeal
approved these changes
Apr 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the start function would be a noop if your callback was something other than a View instance.
With this change, if you use a non-View Callback (such as a Drawable), start will still call playAnimation; if the Callback was a View, it must still not be in edit mode to call playAnimation.