Fix blinking issue when loop the animation in minFrame and maxFrame

airbnb · Apr 25, 2024 · d9c853a · d9c853a
1 parent aebf9bc
commit d9c853a
Showing 1 changed file with 12 additions and 5 deletions.
diff --git a/lottie/src/main/java/com/airbnb/lottie/utils/LottieValueAnimator.java b/lottie/src/main/java/com/airbnb/lottie/utils/LottieValueAnimator.java
@@ -105,18 +105,14 @@ public void setUseCompositionFrameRate(boolean useCompositionFrameRate) {
 
     lastFrameTimeNs = frameTimeNanos;
 
-    if (!useCompositionFrameRate || frameRaw != previousFrameRaw) {
-      notifyUpdate();
-    }
     if (ended) {
       if (getRepeatCount() != INFINITE && repeatCount >= getRepeatCount()) {
         frameRaw = speed < 0 ? getMinFrame() : getMaxFrame();
         frame = frameRaw;
         removeFrameCallback();
+        checkNotifyUpdate(previousFrameRaw);
         notifyEnd(isReversed());
       } else {
-        notifyRepeat();
-        repeatCount++;
         if (getRepeatMode() == REVERSE) {
           speedReversedForRepeatMode = !speedReversedForRepeatMode;
           reverseAnimationSpeed();
@@ -125,7 +121,12 @@ public void setUseCompositionFrameRate(boolean useCompositionFrameRate) {
           frame = frameRaw;
         }
         lastFrameTimeNs = frameTimeNanos;
+        checkNotifyUpdate(previousFrameRaw);
+        notifyRepeat();
+        repeatCount++;
       }
+    } else {
+      checkNotifyUpdate(previousFrameRaw);
     }
 
     verifyFrame();
@@ -134,6 +135,12 @@ public void setUseCompositionFrameRate(boolean useCompositionFrameRate) {
     }
   }
 
+  private void checkNotifyUpdate(float previousFrameRaw) {
+    if (!useCompositionFrameRate || frameRaw != previousFrameRaw) {
+      notifyUpdate();
+    }
+  }
+
   private float getFrameDurationNs() {
     if (composition == null) {
       return Float.MAX_VALUE;