New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add metadata upload to Mussel by team #751
Conversation
def putConf(configPath: String): Future[Seq[Boolean]] = { | ||
// derive team from path to file | ||
def pathToTeam(confPath: String): String = { | ||
// // capture <conf_type>/<team> as key e.g joins/team |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add an example of input and output of the function to the comments?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nikhilsimha updated
Let's generalize this even more. we want to eventually put a lot more metadata. Team/keys -> gbs Feature -> confs For auto complete search: I believe we can write a method that extracts all this metadata in one traversal, without having to parse the files repeatedly. We need a map of endpoint name -> key value extractor |
Hi @nikhilsimha , I think we have two types of key-value pairs:
I am adding two separate functions now |
eeb0c8a
to
8b22df1
Compare
Summary
We want to upload the key-value pair: team -> list of groupBy entities under the key team to mussel.
Why / Goal
Test Plan
Test run log: https://docs.google.com/document/d/1XmwDgBKdDYjabdyUYxW6YRaoBaW8OGe1ZVhWgurECVY/edit?usp=sharing
Checklist
Reviewers
@nikhilsimha