Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pytest-asyncio version conflict #330

Merged
merged 2 commits into from May 13, 2020

Conversation

ojgenbar
Copy link

Description

pytest-asyncio>=0.11 depends on Pytest 5.4.0 and up (details here pytest-dev/pytest-asyncio#142), but requirements.txt states
pytest>=4.4.1,<4.6

That is why make test failing after clonning.

Steps to reproduce:

git clone git@github.com:aiogram/aiogram.git temp_dir123
cd temp_dir123
python3.7 -m venv venv
. venv/bin/activate
pip install -r dev_requirements.txt
make test

This small fix solved it for me.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Manually

Test Configuration:

  • Operating System: Ubuntu 18.04
  • Python version: Python 3.7.5

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@uwinx uwinx changed the title fix: python-asyncio version conflict fix: pytest-asyncio version conflict May 10, 2020
@uwinx
Copy link
Contributor

uwinx commented May 10, 2020

@ojgenbar, great thanks for the PR. do tests run with pytest>=5.4.0? if positive -- maybe we can update pytest itself instead of pytest-asyncio?

@ojgenbar
Copy link
Author

Yeah, I have not tried it.

This configuration works:

pytest>=5.4
pytest-asyncio>=0.10.0

at list for versions:

pytest==5.4.2
pytest-asyncio==0.10.0

and

pytest==5.4.2
pytest-asyncio==0.12.0

@JrooTJunior JrooTJunior merged commit 5eecec7 into aiogram:dev-2.x May 13, 2020
@ojgenbar ojgenbar deleted the fix-pytest-asyncio-version branch May 14, 2020 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants