Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing error logging #1458

Merged
merged 2 commits into from
Apr 23, 2024
Merged

Fix missing error logging #1458

merged 2 commits into from
Apr 23, 2024

Conversation

unintended
Copy link
Contributor

@unintended unintended commented Apr 11, 2024

No error logging when handle_in_background=True

Description

There were no error logging when in handle_in_background=True mode. I changed the call to the one used in synchronous handling mode

Type of change

Please delete options that are not relevant.

  • Documentation (typos, code examples or any documentation update)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Configuration:

  • Operating System:
  • Python version:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@github-actions github-actions bot added the 3.x Issue or PR for stable 3.x version label Apr 11, 2024
Copy link

github-actions bot commented Apr 11, 2024

✔️ Changelog found.

Thank you for adding a description of the changes

Copy link
Member

@JrooTJunior JrooTJunior left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems legit. But it also seems like we need to rethink all feed methods.

@JrooTJunior
Copy link
Member

Please update your branch from the dev-3.x

unintended and others added 2 commits April 23, 2024 11:46
No error logging when handle_in_background=True
Copy link

codecov bot commented Apr 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (4729978) to head (4701a7a).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           dev-3.x     #1458   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          422       422           
  Lines        10937     10937           
=========================================
  Hits         10937     10937           
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
aiogram/dispatcher/dispatcher.py 100.00% <100.00%> (ø)

@JrooTJunior JrooTJunior merged commit f1c9fc5 into aiogram:dev-3.x Apr 23, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.x Issue or PR for stable 3.x version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants