Use typing_extensions only on Python 3.7 and lower #504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Protocol was added with PEP 544 to Python 3.8+
jettify
reviewed
Mar 18, 2023
| # Python 3.8+ | ||
| from typing import Protocol | ||
| except ImportError: | ||
| from typing_extensions import Protocol |
There was a problem hiding this comment.
Files skipped (0):
[46](https://github.com/aio-libs/janus/actions/runs/4158352254/jobs/7329564730?pr=504#step:6:47)
mypy janus --disallow-untyped-calls --disallow-incomplete-defs --strict
[47](https://github.com/aio-libs/janus/actions/runs/4158352254/jobs/7329564730?pr=504#step:6:48)
janus/__init__.py:16: error: Incompatible import of "Protocol" (imported name has type "typing_extensions._SpecialForm", local name has type "<typing special form>") [assignment]
[48](https://github.com/aio-libs/janus/actions/runs/4158352254/jobs/7329564730?pr=504#step:6:49)
Found 1 error in 1 file (checked 1 source file)
[49](https://github.com/aio-libs/janus/actions/runs/4158352254/jobs/7329564730?pr=504#step:6:50)
make: *** [Makefile:31: mypy] Error 1
[50](https://github.com/aio-libs/janus/actions/runs/4158352254/jobs/7329564730?pr=504#step:6:51)
Error: Process completed with exit code 2.
linter issue needs to be addressed.
There was a problem hiding this comment.
yeah, i have no clue how to fix that - obviously they're not gonna be the same type, but they have the same API
|
From other side py3.7 gonna hit EOL in several moth, we gonna drop support as well. |
Python 3.7 is EOL since 2023-06-27 (see endoflife.date or python.org). Would it therefore be possible to drop the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Protocol was added with PEP 544 to Python 3.8+
What do these changes do?
They remove a dependency on the package
typing_extensionswhen it's not neededAre there changes in behavior for the user?
No, it's a change directed at package maintainers for Linux distributions
Checklist
CHANGESfolder<issue_id>.<type>(e.g.588.bugfix)issue_idchange it to the pr id after creating the PR.feature: Signifying a new feature..bugfix: Signifying a bug fix..doc: Signifying a documentation improvement..removal: Signifying a deprecation or removal of public API..misc: A ticket has been closed, but it is not of interest to users.Fix issue with non-ascii contents in doctest text files.