Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): remove deprecated set-output command #348

Closed
wants to merge 2 commits into from
Closed

fix(ci): remove deprecated set-output command #348

wants to merge 2 commits into from

Conversation

dnnsthnnr
Copy link

@dnnsthnnr dnnsthnnr commented Nov 4, 2022

What do these changes do?

Fix the CI Github actions workflow, which was using a deprecated command. https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
It should also fix #342 as it would continue to publish the 3.11 wheels.

Are there changes in behavior for the user?

No.

Related issue number

#342

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modifications, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep the list in alphabetical order, the file is sorted by name.
  • Add a new news fragment into the CHANGES folder
    • name it <issue_id>.<type> for example (588.bugfix)
    • if you don't have an issue_id change it to the pr id after creating the pr
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files."

@Dreamsorcerer
Copy link
Member

Probably better to replace the whole step. setup-python seems to do pip cache simpler and more reliably: https://github.com/aio-libs/aiohttp-demos/pull/196/files#diff-b803fcb7f17ed9235f1e5cb1fcd2f5d3b2838429d4368ae4c57ce4436577f03f

@codecov
Copy link

codecov bot commented Nov 8, 2022

Codecov Report

Merging #348 (5509629) into master (31b492b) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #348   +/-   ##
=======================================
  Coverage   98.36%   98.36%           
=======================================
  Files           1        1           
  Lines          61       61           
  Branches        9        9           
=======================================
  Hits           60       60           
  Misses          1        1           
Flag Coverage Δ
unit 96.72% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mjpieters
Copy link
Collaborator

You'll need to add shell: bash to the step as otherwise it'll use PowerShell on Windows. The old syntax worked on PWS, but not the redirect.

@dnnsthnnr
Copy link
Author

Closed in favor of #352. Thanks @mjpieters

@dnnsthnnr dnnsthnnr closed this Nov 8, 2022
@dnnsthnnr dnnsthnnr deleted the fix/deprecated-ci-command branch November 8, 2022 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CPython 3.11 wheels are not available on PyPI
3 participants