Skip to content

Commit

Permalink
CI: detect test matrix failure correctly
Browse files Browse the repository at this point in the history
We were missing always(), and use the alls-green action to verify the status of
the test matrix jobs. Without always() the check step was being skipped
whenever a test failed. 🤦
  • Loading branch information
mjpieters committed Nov 8, 2022
1 parent a077c43 commit 768c944
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 3 deletions.
8 changes: 5 additions & 3 deletions .github/workflows/ci.yml
Expand Up @@ -120,10 +120,12 @@ jobs:
name: Test matrix status
runs-on: ubuntu-latest
needs: [test]
if: always()
steps:
- name: Check build matrix status
if: needs.test.result != 'success'
run: exit 1
- name: Decide whether the needed jobs succeeded or failed
uses: re-actors/alls-green@release/v1
with:
jobs: ${{ toJSON(needs) }}

pre-deploy:
name: Pre-Deploy
Expand Down
1 change: 1 addition & 0 deletions CHANGES/327.misc
@@ -0,0 +1 @@
Updated the CI runs to better check for test results and to avoid deprecated syntax.

0 comments on commit 768c944

Please sign in to comment.