Raise exact mysql error when the packet is an error packet #975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #975 +/- ##
==========================================
+ Coverage 93.68% 93.75% +0.07%
==========================================
Files 36 36
Lines 5538 5553 +15
Branches 895 899 +4
==========================================
+ Hits 5188 5206 +18
+ Misses 260 258 -2
+ Partials 90 89 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Raise more exact mysql error when the packet is an error packet.
Add logic in _read_packet method to check the packet's first bytes, if it's error packet then raise the exact mysql error returned from server.
I run int to this issue #971 , the message is "InternalError: Packet sequence number wrong...", when I debug more, I find out the packet is an error packet and the packet number is 1 when it is expected to be 2, this case happens when the network is bad, and read data timeout when connect, the real error message is (1159, Got timeout reading communication packets). I think its better to return the exact mysql error, so we can find out what is wrong really.
#971
Checklist