Implement 'read_timeout' parameter #974
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aakulchyk
force-pushed
the
master
branch
2 times, most recently
from
185b943
to
4b6fb3c
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -1,13 +1,13 @@ | |||
| from unittest import mock | |||
|
|
|||
| import aiomysql | |||
Check notice
Code scanning / CodeQL
Module is imported with 'import' and 'import from' Note
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Support 'read_timeout' parameter of the connection object from pymysql:
https://pymysql.readthedocs.io/en/latest/modules/connections.html#module-pymysql.connections
Are there changes in behaviour for the user?
The connection will be closed if timeout is reached (same behaviour as in pymysql)
Related issue number
#488
Checklist