Bump SQLAlchemy version to 1.4 #940
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nothing4You
added
dependencies
Nothing4You
force-pushed
the
sqlalchemy-1.4
branch
from
3e73bfe
to
e856063
Compare
Codecov Report
@@ Coverage Diff @@
## master #940 +/- ##
==========================================
- Coverage 93.68% 93.62% -0.06%
==========================================
Files 36 36
Lines 5538 5538
Branches 895 895
==========================================
- Hits 5188 5185 -3
- Misses 260 263 +3
Partials 90 90
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Update SQLAlchemy dependency to 1.4.
Are there changes in behavior for the user?
SQLAlchemy <1.4 will no longer be supported.
Related issue number
wip notes
Relevant SQLAlchemy changes:
https://docs.sqlalchemy.org/en/14/changelog/migration_14.html#change-4645
This should port aio-libs/aiopg#806.
The aiopg PR indicates that this might need to be implemented differently due to aiomysql supporting
executemany.Since #294, aiomysql also supports compiled cache, which on first look seems to need additional care.
#577 (comment) has a monkeypatch snippet for
SAConnection._execute.I'm personally not an SQLAlchemy user, so if someone can contribute additional test cases, patches or review I'd appreciate it.
Also needs to port aio-libs/aiopg#891.
Checklist
CHANGES.txt