Support non-standard implicit TLS connections, such as Google Cloud SQL #786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #786 +/- ##
==========================================
- Coverage 93.66% 92.52% -1.14%
==========================================
Files 36 38 +2
Lines 5507 5565 +58
Branches 931 944 +13
==========================================
- Hits 5158 5149 -9
- Misses 262 325 +63
- Partials 87 91 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
1 task
Nothing4You
force-pushed
the
explicit-tls
branch
2 times, most recently
from
3d0c9f1
to
6dd7caa
Compare
Nothing4You
force-pushed
the
explicit-tls
branch
9 times, most recently
from
3f4555d
to
24c3157
Compare
…onnections, such as Google Cloud SQL fixes aio-libs#757
Nothing4You
force-pushed
the
explicit-tls
branch
from
8793725
to
173eb36
Compare
|
not sure why mysql 8.0 fails auth through haproxy, it works just fine when i run it locally, although without containers. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
This adds a new
implicit_tlsargument when creating connections.When this argument is given, the initial non-TLS preamble is skipped and the connection will be upgraded to TLS immediately.
Are there changes in behavior for the user?
No change in default behavior.
Related issue number
fixes #757
Checklist
--mysql-tls-addressto generate an extra set of tests in the matrix.this will run all tests on an implicit-TLS-connection when provided.
CHANGES.txtOnce everything else has been done