add python 3.11 tests #722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #722 +/- ##
========================================
Coverage 92.69% 92.69%
========================================
Files 35 35
Lines 5432 5436 +4
Branches 586 914 +328
========================================
+ Hits 5035 5039 +4
Misses 309 309
Partials 88 88
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Nothing4You
force-pushed
the
py3.11-tests
branch
from
3468792
to
fd8f849
Compare
uvloop is disabled on python 3.11 for now due to cython incompatibility. a new cython version has since been released but uvloop needs to be built against this new cython version. see MagicStack/uvloop#450 and MagicStack/uvloop#459
Nothing4You
force-pushed
the
py3.11-tests
branch
from
fd8f849
to
c64ca30
Compare
|
tests on py3.11 randomly fail: https://github.com/aio-libs/aiomysql/runs/5000103904?check_suite_focus=true#step:12:11 re-running the tests will succeed. I haven't had time to try to repro this locally yet to see if I can figure out a consistently reproducible case. |
|
after some extensive testing I was finally able to determine the root cause of these failures to be in coverage.py: nedbat/coveragepy#1316 |
Nothing4You
added a commit
that referenced
this pull request
Jan 31, 2022
This reverts commit c0972d2. coverage.py still has issues with Python 3.11, there's not much point in keeping them if they segfault half the time. nedbat/coveragepy#1316
Nothing4You
added a commit
that referenced
this pull request
Feb 1, 2022
This reverts commit c0972d2. coverage.py still has issues with Python 3.11, there's not much point in keeping them if they segfault half the time. nedbat/coveragepy#1316
Nothing4You
added a commit
that referenced
this pull request
Feb 2, 2022
uvloop is disabled on python 3.11 for now due to cython incompatibility. a new cython version has since been released but uvloop needs to be built against this new cython version. see MagicStack/uvloop#450 and MagicStack/uvloop#459
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
add python 3.11 tests.
uvloop is disabled on python 3.11 for now due to cython incompatibility.
a new cython version has since been released but uvloop needs to be built against this new cython version.
see MagicStack/uvloop#450 and MagicStack/uvloop#459
Are there changes in behavior for the user?
no