Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepared statement #508

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Prepared statement #508

wants to merge 10 commits into from

Conversation

wwwjfy
Copy link

@wwwjfy wwwjfy commented Jun 28, 2020

What do these changes do?

Implement MySQL Prepared Statements

Are there changes in behavior for the user?

No change to existing features.

Related issue number

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • Add a new news fragment into the CHANGES folder
    • name it <issue_id>.<type> (e.g. 588.bugfix)
    • if you don't have an issue_id change it to the pr id after creating the PR
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example: Fix issue with non-ascii contents in doctest text files.

@lgtm-com
Copy link

lgtm-com bot commented Jun 28, 2020

This pull request fixes 1 alert when merging e1e6621 into d842ec3 - view on LGTM.com

fixed alerts:

  • 1 for Module-level cyclic import

@lgtm-com
Copy link

lgtm-com bot commented Jun 28, 2020

This pull request fixes 1 alert when merging f6ca5f9 into d842ec3 - view on LGTM.com

fixed alerts:

  • 1 for Module-level cyclic import

@codecov
Copy link

codecov bot commented Jun 28, 2020

Codecov Report

Merging #508 (e352475) into master (d842ec3) will decrease coverage by 5.05%.
The diff coverage is 74.63%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #508      +/-   ##
==========================================
- Coverage   87.54%   82.48%   -5.06%     
==========================================
  Files           9       13       +4     
  Lines        1228     2312    +1084     
  Branches      177      357     +180     
==========================================
+ Hits         1075     1907     +832     
- Misses        124      316     +192     
- Partials       29       89      +60     
Impacted Files Coverage Δ
aiomysql/prepared_statement.py 72.41% <72.41%> (ø)
aiomysql/utils.py 87.15% <85.71%> (-0.22%) ⬇️
aiomysql/connection.py 77.45% <86.20%> (ø)
aiomysql/cursors.py 92.55% <100.00%> (ø)
aiomysql/sa/__init__.py 100.00% <0.00%> (ø)
aiomysql/__init__.py 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d842ec3...e352475. Read the comment docs.

@lgtm-com
Copy link

lgtm-com bot commented Jun 28, 2020

This pull request fixes 1 alert when merging 20a439f into d842ec3 - view on LGTM.com

fixed alerts:

  • 1 for Module-level cyclic import

@lgtm-com
Copy link

lgtm-com bot commented Jun 28, 2020

This pull request fixes 1 alert when merging c9f603a into d842ec3 - view on LGTM.com

fixed alerts:

  • 1 for Module-level cyclic import

@wwwjfy
Copy link
Author

wwwjfy commented Jun 28, 2020

Tests failed because of JSON is not supported in MariaDB 5.5
It is no longer supported officially. Can we drop it in Travis?

@lgtm-com
Copy link

lgtm-com bot commented Jun 28, 2020

This pull request fixes 1 alert when merging e352475 into d842ec3 - view on LGTM.com

fixed alerts:

  • 1 for Module-level cyclic import

@Nothing4You
Copy link
Collaborator

Thank you for the PR, unfortunately due to aiomysql being based on PyMySQL this should first be implemented in PyMySQL and then ported to aiomysql.

see PyMySQL/PyMySQL#202 for the related issue in PyMySQL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement pymysql pymysql-blocked Pending implementation in PyMySQL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants