Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: use of echo at connection, and new cursor with echo option from … #500

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

rspadim
Copy link

@rspadim rspadim commented Jun 13, 2020

…connection

What do these changes do?

Include logger.debug() message at _execute() connection function

Are there changes in behavior for the user?

yes, when connection echo = True, will log more messages, instead of only cursor echo messages, but it's much much more usefull since we can trace autocommit , commit, begin, rollback messages, this helps a lot when debuging deadlocks

Related issue number

#498

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • Add a new news fragment into the CHANGES folder
    • name it <issue_id>.<type> (e.g. 588.bugfix)
    • if you don't have an issue_id change it to the pr id after creating the PR
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example: Fix issue with non-ascii contents in doctest text files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants