[WIP] 🏷️ Add type hints #911
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| self._conn = None | ||
|
|
||
|
|
||
| class _PoolConnectionContextManager: |
Check failure
Code scanning / CodeQL
`__iter__` method returns a non-iterator Error
| def setoutputsizes(self, *args): | ||
| """Does nothing, required by DB API.""" | ||
|
|
||
| async def nextset(self): |
Check notice
Code scanning / CodeQL
Explicit returns mixed with implicit (fall through) returns Note
| logger.info("%r", args) | ||
| return self._rowcount | ||
|
|
||
| async def executemany(self, query, args): |
Check notice
Code scanning / CodeQL
Explicit returns mixed with implicit (fall through) returns Note
| row = self._conv_row(row) | ||
| return row | ||
|
|
||
| async def fetchone(self): |
Check notice
Code scanning / CodeQL
Explicit returns mixed with implicit (fall through) returns Note
What do these changes do?
This pull request adds type hints to aiomysql, making it easier for developers to understand the API and to use the library in their code. Due to cyclic dependencies between the cursor and connection classes, two files have been merged into one. Additionally, the _ContextManager class has been generalized as much as possible to improve code reuse and maintainability.
Related issue number
#707
Checklist
CHANGESfolder