Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type hints #707

Open
Nothing4You opened this issue Jan 30, 2022 · 4 comments
Open

Add type hints #707

Nothing4You opened this issue Jan 30, 2022 · 4 comments

Comments

@Nothing4You
Copy link
Collaborator

see also aio-libs/aiopg#813 for context managers

@DavidRomanovizc
Copy link

Hello, @Nothing4You, I think I can try to do it if there is still a need for it.
But I have a little problems with aiomysql:

  • When I run the make test command I get an error message:
    • python -m twine check --strict dist/*
      ERROR InvalidDistribution: Cannot find file (or expand pattern): 'dist/*'
  • In the aiomysql/connection.py cannot import
    • EOFPacketWrapper
    • LoadLocalPacketWrapper
    • OKPacketWrapper
    • TEXT_TYPES
    • MAX_PACKET_LEN
    • _auth
    • CR
    • escape_bytes_prefixed
    • through

It will be great if you help me with these problems so that I can start dealing with the issue faster.

@cyrus01337
Copy link

@DavidRomanovizc I see that you still have your fork available, though it's last update on main (the only branch there) was in March 6th. If you could push the changes to create a reproducible environment, I think this would help in creating a solution, and others as well as I could take a look too.

@DavidRomanovizc
Copy link

DavidRomanovizc commented May 4, 2023

@DavidRomanovizc I see that you still have your fork available, though it's last update on main (the only branch there) was in March 6th. If you could push the changes to create a reproducible environment, I think this would help in creating a solution, and others as well as I could take a look too.

Yes, I will try to update the my branch soon

@Nothing4You Nothing4You linked a pull request May 6, 2023 that will close this issue
4 tasks
@Nothing4You
Copy link
Collaborator Author

Hi @DavidRomanovizc,
the Makefile has not been updated when updating the CI/test changes when it was migrated to GitHub actions, so not everything may be working properly currently.
As I'm working on macOS, it's not as easy for me to use containers for testing, as they're not natively supported, so for myself I've mostly been running pytest manually.
I've been using on my local machine e.g. MYSQL_ROOT_PASSWORD="" python -m pytest --color=yes --verbosity 2 --cov aiomysql --cov tests ./tests --mysql-address tcp.mysql80=localhost:3306 --mysql-unix-socket unix.mysql80=/tmp/mysql.sock --cov-report html -s -W always before pushing code to GitHub and letting GH actions process across different databases.
You can find the command used by GitHub actions here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants